Opened 9 years ago

Closed 9 years ago

#5681 closed Bug (wontfix)

'menubutton' force focus

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: UI : Context Menu Version:
Keywords: Confirmed Review? Cc: WebSpellChecker.net

Description

Currently the menu created by 'menubutton' plugin will always force focusing the editor on show and close, observed on SCAYT menu, the expected behavior is that focus should be set only when necessary.

Attachments (1)

5681.patch (1.1 KB) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Garry Yao

Attachment: 5681.patch added

comment:1 Changed 9 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

It may be simpler and safer to instead have a property in the CKEDITOR.plugins.contextMenu class, like CKEDITOR.plugins.contextMenu.editorFocus = true. It sounds less prone to error. It can default to true.

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3
Resolution: wontfix
Status: assignedclosed

In fact, I don't see a problem of having menu buttons focusing the editor. After all, those buttons are related to the editor. Let's leave it this way for now, and check if we'll have troubles with it in the future.

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? added; Review- removed
Resolution: wontfix
Status: closedreopened

This feature is required by SCAYT now: http://dev.fckeditor.net/ticket/5570#comment:11

comment:5 in reply to:  2 Changed 9 years ago by Garry Yao

Milestone: CKEditor 3.3

Replying to fredck:

It may be simpler and safer to instead have a property in the CKEDITOR.plugins.contextMenu class, like CKEDITOR.plugins.contextMenu.editorFocus = true. It sounds less prone to error. It can default to true.

The 'editorFocus ' is a dynamic property depends on the opening moment of the menu, so it can't be a constructor field.

comment:6 in reply to:  4 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3
Resolution: wontfix
Status: reopenedclosed

Replying to garry.yao:

This feature is required by SCAYT now

It should not be: comment:ticket:5570:13.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy