Ticket #5688 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

UI dialog for the second instance fails

Reported by: alfonsoml Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

Loading the ui color samples, the dialog that it's launched in second place to change the ui color lacks the color picker.

Attachments

5688.patch (6.4 KB) - added by alfonsoml 4 years ago.
Proposed patch
5688_2.patch (35.8 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 4 years ago by alfonsoml

Regression of [5412]

Changed 4 years ago by alfonsoml

Proposed patch

comment:2 Changed 4 years ago by alfonsoml

  • Status changed from new to assigned
  • Keywords Review? added
  • Owner set to alfonsoml
  • Milestone set to CKEditor 3.4

At least we must fix it for 3.4, although I think that it's safe (and better) to fix it in 3.3

comment:3 Changed 4 years ago by alfonsoml

  • Keywords Review? removed
  • Milestone changed from CKEditor 3.4 to CKEditor 3.3

This is worse than the initial description: any 'html' element in a dialog will be reused in the second instance if they are managed with the html id and getElementById.

Example: launch the image dialog in one instance, now open it again in the second instance and the lock and reset size buttons don't work.

We must look at every "type : 'html'," definition in the dialogs.

Changed 4 years ago by garry.yao

comment:4 Changed 4 years ago by garry.yao

  • Keywords Confirmed Review? added

As pointed by Alfonso, we should eliminate all DUP ids inside dialogs, I've grabbed them with this tool scripts:

void($('[id]').each(function(){
  var ids = $('[id='+this.id+']');
  if(ids.length>1 && ids[0]==this)
    console.log( this.id );
}));

comment:5 Changed 4 years ago by garry.yao

The chunks of changes in 'image' plugin were actually moving function scope instead of actually change anything.

comment:6 Changed 4 years ago by garry.yao

  • Status changed from assigned to new
  • Owner changed from alfonsoml to garry.yao

comment:7 Changed 4 years ago by alfonsoml

  • Keywords Review- added; Review? removed

Can you fix at the same time the little typo in "smiley_emtions_label"?

And the changes in the flash dialog could be just to remove those ids (without adding new ones as they aren't used) and put the class to the second div. In fact, I'm not sure that the first div is used at all, but that's another bug.

'<div style="display:none"><div class="loading">&nbsp;</div></div>' +
'<div class="FlashPreviewBox"></div></div>';

In the image dialog, the preview doesn't work in the second instance

comment:8 Changed 4 years ago by alfonsoml

  • Keywords Review+ added; Review- removed

Sorry, I got confused and didn't test the correct files.

comment:9 Changed 4 years ago by garry.yao

  • Status changed from new to assigned

Fixed with [5504].

comment:10 Changed 4 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy