UI dialog for the second instance fails

[Alfonso Martínez de Lizarrondo]

Loading the ui color samples, the dialog that it's launched in second place to change the ui color lacks the color picker.

[Alfonso Martínez de Lizarrondo]

Regression of [5412]

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

At least we must fix it for 3.4, although I think that it's safe (and better) to fix it in 3.3

[Alfonso Martínez de Lizarrondo]

This is worse than the initial description: any 'html' element in a dialog will be reused in the second instance if they are managed with the html id and getElementById.

Example: launch the image dialog in one instance, now open it again in the second instance and the lock and reset size buttons don't work.

We must look at every "type : 'html'," definition in the dialogs.

[Garry Yao]

As pointed by Alfonso, we should eliminate all DUP ids inside dialogs, I've grabbed them with this tool scripts:

void($('[id]').each(function(){
  var ids = $('[id='+this.id+']');
  if(ids.length>1 && ids[0]==this)
    console.log( this.id );
}));

[Garry Yao]

The chunks of changes in 'image' plugin were actually moving function scope instead of actually change anything.

[Alfonso Martínez de Lizarrondo]

Can you fix at the same time the little typo in "smiley_emtions_label"?

And the changes in the flash dialog could be just to remove those ids (without adding new ones as they aren't used) and put the class to the second div. In fact, I'm not sure that the first div is used at all, but that's another bug.

'<div style="display:none"><div class="loading">&nbsp;</div></div>' +
'<div class="FlashPreviewBox"></div></div>';

In the image dialog, the preview doesn't work in the second instance

[Alfonso Martínez de Lizarrondo]

Sorry, I got confused and didn't test the correct files.

[Garry Yao]

Fixed with [5504].