Opened 9 years ago
Closed 9 years ago
#5689 closed Bug (fixed)
Adjustments for WriteArea
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
In order to port WriteArea to use CKEditor some minor adjustments are needed.
The first one might also help in other environments if access to document.domain is restricted, the second one should affect only code running in the Firefox chrome.
Attachments (1)
Change History (7)
Changed 9 years ago by
| Attachment: | 5689.patch added |
|---|
comment:1 Changed 9 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
We'd use adapter instead of modifying core codes for non-browser compatibility, e.g. Mozilla application, Adobe AIR, ActiveX Objects.
comment:2 Changed 9 years ago by
| Keywords: | Confirmed Review? added; Review- removed |
|---|---|
| Resolution: | invalid |
| Status: | closed → reopened |
I understand the reason behind Garry's comments, but in this case the changes are so minimal that we could take it in consideration. We must just be sure the changes on isCustomDomain will not break anything.
comment:3 Changed 9 years ago by
| Keywords: | Confirmed removed |
|---|---|
| Status: | reopened → confirmed |
comment:4 Changed 9 years ago by
| Keywords: | Review? removed |
|---|---|
| Owner: | changed from Alfonso Martínez de Lizarrondo to Wiktor Walc |
| Status: | confirmed → review |
comment:5 Changed 9 years ago by
| Status: | review → review_passed |
|---|
Please be sure to add proper comments on L326 and L343 and fix the coding style issues on L327 and L344 before commiting.
comment:6 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [5752]
Proposed patch