Opened 7 years ago

Closed 7 years ago

#5690 closed Bug (fixed)

When editing a table cell with a width="xxx%" attribute, the cell properties dialog shows pixels instead of percentage

Reported by: Jonathon Sim Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4
Component: General Version:
Keywords: Confirmed Cc:

Description

If your source contains a table cell with a percentage width attribute eg:

<td width="50%">

and you right click > cell > cell properties the resulting dialog will show:

Width: 50 pixels

ie it will select "pixels" rather than "percentage" in the "widthType" dropdown.

Saving this dialog will then insert

<td style="width: 50px">

which is obviously wrong.

You can reproduce this on the nightly build (edit your source and insert a percentage width attribute and reproduce the steps described above)

The attached patch fixes this issue

Attachments (2)

table-cell-width-fix.diff (603 bytes) - added by Jonathon Sim 7 years ago.
5690.patch (676 bytes) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Jonathon Sim

Attachment: table-cell-width-fix.diff added

comment:1 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: HasPatch added
Milestone: CKEditor 3.4

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 5690.patch added

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Confirmed Review? added; HasPatch removed
Owner: set to Sa'ar Zac Elias
Status: newassigned

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5726].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy