Opened 7 years ago

Closed 7 years ago

#5715 closed Bug (fixed)

Cell color picker dialog returns focus to document

Reported by: Tobiasz Cudnik Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: UI : Dialogs Version: 3.1
Keywords: Cc:

Description

Cell color picker dialog returns focus to document.

Reproduce

  1. Use content with some table, eg:
    <table>
    	<tbody>
    		<tr>
    			<td>
    				TD</td>
    		</tr>
    	</tbody>
    </table>
    
  2. Open cell properties dialog (context menu -> Cell -> Cell properties).
  3. Open background/border color picker.
  4. Close second dialog (color picker).
  5. Hit TAB.

Result

  1. Focus is gained by main document and tabbed are page elements.

Expected

  1. Focus goes back to Cell properties dialog.

I'm setting milestone to 3.3 as this may be related to #4649.

Attachments (2)

5715.patch (2.2 KB) - added by brooks 7 years ago.
5715_2.patch (621 bytes) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4

comment:2 Changed 7 years ago by brooks

Owner: set to brooks
Status: newassigned

Changed 7 years ago by brooks

Attachment: 5715.patch added

comment:3 Changed 7 years ago by brooks

Keywords: review? added

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review? added; review? removed

comment:5 Changed 7 years ago by Garry Yao

Component: GeneralUI : Dialogs
Keywords: Confirmed Review- added; Review? removed
Version: 3.1

colorPickerDialog._.parentDialog should be used instead of passing the extra param.

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:7 Changed 7 years ago by Tobiasz Cudnik

Owner: changed from brooks to Tobiasz Cudnik
Status: review_failedassigned

Reowning after Brooks.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 5715_2.patch added

comment:8 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

Simplified patch.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Confirmed removed
Status: reviewreview_passed

comment:10 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5845].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy