SCAYT set focus on mode switch

[Garry Yao]

Reproducing Procedures

1. Make sure SCAYT is enabled, then put focus into editor;
2. Switch to 'Source' mode and switch back.
   • Actual Result: The cursor is blinking at the start of document.
   • Expected Result: Editor should gain no focus.

[Garry Yao]

Scope of 'is_control_restored' must NOT be on global.

[WebSpellChecker.net]

patch proposed which make 'is_control_restored' non global

[Garry Yao]

Why the 'restored' flag is never get reverted?

[WebSpellChecker.net]

This flag is used in scayt.onLoad handler which is called

1. when SCAYT just initialzied it should set focus to editable control only if editor.focusManager.hasFocus is set to true (restored flag set to false)
2. when SCAYT is re-enabled (restored) (Source->WYSIWYG), editor.focusManager.hasFocus is set to true so scayt.onLoad will set the focus anyway. Setting the 'restored' flag will prevent setting of focus.

May be name of this variable is not suitable for this purpose?

During preparation of this fix we have discovered problem with other variable - control_id - which is also global. On the page with multiple editors enabling/disabling SCAYT follow to JS error. We are in progress preparing one mroe patch.

[Garry Yao]

Does 'restored' keep staying 'true' once switched from 'Source'?

[Frederico Caldeira Knabben]

In fact, the behavior we're having because of SCAYT is desirable, but the problem is that it should not be a SCAYT job to do that. So for now, let's leave it as it is, have another ticket that uniforms this behavior even without SCAYT and also in source mode.

[WebSpellChecker.net]

This patch fix whole problem with scayt's global vars and its states storing Similar problems is reported in #5741 and all of them fixed with 5720_3.patch