Ticket #5728 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Text field & Upload Button in Upload Tab of Image Properties dialog are not shown Properly in Arabic

Reported by: satya Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.2
Keywords: IBM Review+ Cc: damo,joek

Description

To reproduce the defect

  1. open http://nightly.ckeditor.com/5508/_samples/ui_languages.html
  1. Click on Image Toolbar icon dialog and Click on Upload Tab on Image Properties dialog
  1. Take a Screen shot of it.
  1. Change the Language to Arabic and Click on Image Toolbar icon again and Click on Upload Tab on Image Properties dialog

Expected Result:

The Fields on the upload Tab of Image Properties should be shown as Exact Mirror Image of the same Fields in English Language.

Actual Result:

The Upload Text Field and Upload buttons on the upload Tab of Image Properties dialog are not shown as Mirror Image of the same Fields in English Language.

I am attaching the Screen shots of the Upload Tab of Image dialog in both English and Arabic

Attachments

Upload Tab on Img dialog in Arabic.jpg (17.3 KB) - added by satya 4 years ago.
Upload Tab on Img dialog in En.jpg (19.5 KB) - added by satya 4 years ago.
5728_1.patch (1.4 KB) - added by tobiasz.cudnik 4 years ago.

Change History

Changed 4 years ago by satya

Changed 4 years ago by satya

comment:1 Changed 4 years ago by fredck

We'll check it, but this field is rendered by the browser (<input type="file">), so it may work properly only on Arabic browsers.

comment:2 Changed 4 years ago by damo

Is this not just a matter of adding dir="rtl" to both the file input and the enclosing form?

comment:3 Changed 4 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik

Changed 4 years ago by tobiasz.cudnik

comment:4 Changed 4 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Keywords Review? added

Adding dir="rtl" to form makes file field reverted. I've added it additionally to iframe's HTML element along with lang attribute.

comment:5 Changed 4 years ago by garry.yao

  • Keywords Review+ added; Review? removed

Just wonder the necessity of "dir" on form element, please confirm before commit.

comment:6 Changed 4 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5673].

comment:7 Changed 4 years ago by tobiasz.cudnik

Committed into correct branch with [5696].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy