Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#5799 closed Bug (fixed)

liststyle plugin doesn't state required plugins

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.3
Keywords: Cc:

Description

The liststyle plugin doesn't have a "requires" statement about what plugins it needs, and although it tries to detect the availability of the contextMenu, the editor.addMenuGroup isn't protected.

http://cksource.com/forums/viewtopic.php?f=11&t=18990

The code could be changed also to state that the contextmenu is required and remove the "if"s in the code, but I think that this way it can allow for other people for example to create a toolbar button for them even if they disable the contextmenu.

Attachments (1)

5799.patch (1023 bytes) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 5799.patch added

Proposed patch

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4
Status: reviewreview_passed

comment:2 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: review_passedclosed

Fixed with [5732]

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

#6095 has been marked as DUP.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy