Opened 9 years ago
Closed 9 years ago
#5943 closed Bug (fixed)
Incorrect handling of height and width value in image dialog
| Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Review+ | Cc: |
Description
Steps to reproduce
- Open a sample in IE and open the image dialog.
- Go to the height or width fields, and type a value that ends with percent sign or the 'px' suffix.
An error occurs.
Attachments (2)
Change History (8)
Changed 9 years ago by
| Attachment: | 5943.patch added |
|---|
comment:1 Changed 9 years ago by
| Status: | new → assigned |
|---|
comment:2 Changed 9 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Milestone: | CKEditor 3.4 |
Changed 9 years ago by
| Attachment: | 5943_2.patch added |
|---|
comment:3 Changed 9 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Milestone: | → CKEditor 3.4 |
That was my original thought, but looking at the code I realized that there is an intention to accept values with the percent sign and the 'px' suffix. I'm attaching a new patch that adds the 'px' suffix if necessary.
comment:4 Changed 9 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Ok... that's a good way for it also.
comment:6 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Well... we still need to have the "px" if only a number is provided.
The thing is that the dialog has been created to accept only numbers on the dimension fields. So, if anything is to be done here, we must simply provide validation on those fields.