Opened 7 years ago

Closed 7 years ago

#6004 closed Bug (fixed)

[3.4.x] Styles not being applied to collapsed selection

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.4
Component: Core : Styles Version:
Keywords: Cc:

Description

There is no effect when trying to apply styles (like bold) in collapsed selections.

Attachments (2)

6004.patch (2.3 KB) - added by Frederico Caldeira Knabben 7 years ago.
6004_2.patch (2.3 KB) - added by Frederico Caldeira Knabben 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Status: newconfirmed

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: 6004.patch added

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: confirmedreview

I've reverted the original selection way for collapsed selections, additionally adding a new "collapsed" property for bookmarks.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

The proposed patch leaves bookmark nodes in the contents, noticeable in IE when applying styles to a collapsed selection in the middle of a word.

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: 6004_2.patch added

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Status: review_failedreview

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [5744].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy