[3.4.x] Error when pasting over read-only blocks

[Frederico Caldeira Knabben]

1. Load the following HTML:

<p>
	Para 1</p>
<p contenteditable="false">
	Para 2</p>
<p>
	Para 3</p>

2. Right-click "Para 2".
3. Paste and allow clipboard access.

A js error is thrown.

Confirmed with IE8.

[Frederico Caldeira Knabben]

The root of the problem is an IE bug with contenteditable=false stuff.

To illustrate, on the tc, when right-clicking, we have the following selection:

<p>
	Para 1[</p>
<p contenteditable="false">
	Para 2]</p>
<p>
	Para 3</p>

So, the selection is inside the read-only element, instead of containing it entirely. This fact makes IE break when calling pasteHTML (unspecified error!).

To workaround it, we need to make the checks proposed in the patch, eventually fixing the selection.

To properly achieve it, I had to change range.checkBoundaryOfElement a bit, so I had also to fix its usage in the styles plugin.

[Sa'ar Zac Elias]

• The first and last paragrpahs are merged with the pasted content between them, I believe the expected is that the pasted content would be between them.
• There is a bookmark left in the content.

[Frederico Caldeira Knabben]

Replying to Saare:

• The first and last paragrpahs are merged with the pasted content between them, I believe the expected is that the pasted content would be between them.

This is out of the scope of this ticket. Please open a dedicated ticket for it.

• There is a bookmark left in the content.

I'm not able to reproduce it. Can you give us more information on how to see the issue?

[Sa'ar Zac Elias]

Filed #6033.
I can reproduce the problem with the bookmark in IE8.

[Frederico Caldeira Knabben]

Ok, I'm able to reproduce it also, in IE8+Standards mode. But it has nothing to do with this ticket. It happens before patch also.

Please open a dedicated ticket for it. I'll investigate it meanwhile.

[Frederico Caldeira Knabben]

Also... that bookmark issue is reproducible on trunk.

[Frederico Caldeira Knabben]

For reference, the bookmark issue will be handled at #6035.

[Frederico Caldeira Knabben]

Fixed with [5748].