Opened 14 years ago
Closed 14 years ago
#6020 closed Bug (fixed)
Copy and cut icons should be disabled on empty selection
| Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | General | Version: | 3.0 |
| Keywords: | Oracle | Cc: | satya_minnekanti@… |
Description
Copy and cut toolbar buttons should be disabled when the selection is empty.
Attachments (5)
Change History (24)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 14 years ago by
comment:3 Changed 14 years ago by
| Cc: | satya_minnekanti@… added |
|---|
comment:4 Changed 14 years ago by
| Keywords: | Oracle added |
|---|
comment:5 Changed 14 years ago by
| Owner: | set to Martin |
|---|---|
| Status: | confirmed → assigned |
Changed 14 years ago by
| Attachment: | 6020.patch added |
|---|
comment:6 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:7 Changed 14 years ago by
| Milestone: | → CKEditor 3.5.1 |
|---|
comment:8 Changed 14 years ago by
| Owner: | changed from Martin to Sa'ar Zac Elias |
|---|---|
| Status: | review → assigned |
I'm taking this one over @mani.
Changed 14 years ago by
| Attachment: | 6020_2.patch added |
|---|
comment:9 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:10 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Not an option, keyboard hook brings serious performance just like #6438.
Changed 14 years ago by
| Attachment: | 6020_3.patch added |
|---|
comment:11 Changed 14 years ago by
| Status: | review_failed → review |
|---|
Another approach is to use queryCommandEnabled and hook the selectionChange for readOnly check.
comment:12 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Looks good, while readonly doesn't affect "paste" command state.
Changed 14 years ago by
| Attachment: | 6020_4.patch added |
|---|
comment:13 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:14 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Let's also check whether the paste command state need to be constantly checked.
comment:15 Changed 14 years ago by
| Status: | review_failed → review |
|---|
queryCommandEnabled is false when there is no data to paste (probably other limitations as well). In Webkit, it will always return false for security reasons (#3788). In any case, the toolbar buttons' state should match the context menu's options.
comment:16 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Other two paste commands could be aligned also. (paste plain text and paste word)
Changed 14 years ago by
| Attachment: | 6020_5.patch added |
|---|
comment:17 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:18 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:19 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6311].
#6239 has been marked has a DUP.