Opened 14 years ago
Closed 14 years ago
#6027 closed Bug (fixed)
[[FF]] Modifying Table Properties by selecting more than one cell, causing several issues
Reported by: | Satya Minnekanti | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.1 |
Component: | General | Version: | 3.3 |
Keywords: | IBM | Cc: | Damian, joek |
Description
To reproduce the defect:
- open Ajax sample.
- Insert a Table with 5 rows & 6 columns.
- Select more than one cell( for ex: Top 2 cells) and click on Table Properties option.
- Try to modify any of Table Properties and Click OK button.
Expected Result:
Table properties should be modified successfully.
Actual Result:
we are getting the following error in firebug when we press OK button
k.$ is undefined [Break on this error] h.get=function(i){return i&&(i.$?i:new...turn c?i.replace(/<\?[>]*>/g,):i;
and also when we press cancel and close the dialog, the last Table cell that was selected gets deleted.
And also it is giving the option to edit the No of Rows & Columns for the user which it should not be.
Attachments (2)
Change History (10)
comment:1 Changed 14 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 14 years ago by
Milestone: | → CKEditor 3.5 |
---|
comment:3 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | confirmed → assigned |
Changed 14 years ago by
Attachment: | 6027.patch added |
---|
comment:4 Changed 14 years ago by
Status: | assigned → review |
---|
comment:5 Changed 14 years ago by
Status: | review → review_failed |
---|
Changed 14 years ago by
Attachment: | 6027_2.patch added |
---|
comment:6 Changed 14 years ago by
Status: | review_failed → review |
---|
comment:7 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:8 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5820].
The fix is correct, but now that "if" block results redundant, because selectedTable will already be null (or undefined) if getAscendant doesn't find the table. The code should get simplified.