Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6028 closed New Feature (wontfix)

BIDI: Tables should align to corresponding direction when base language direction is set

Reported by: Damian Owned by:
Priority: Normal Milestone:
Component: General Version: SVN (CKEditor) - OLD
Keywords: IBM Cc: Joe Kavanagh Satya

Description

When setting a table's base language direction, its alignment should also be set to correspond to the direction.

E.g. When setting the base language direction to RTL the table alignment should switch to align=right.

The alignment can then be overridden by a user if they wish.

Change History (4)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

There is an important issue with this though. As soon as the table receives the align="right" attribute, it starts "floating", so the rest of the text contents will be rendered at the same vertical space as it is.

Let me try to illustrate it, having a table between two paragraphs:

Expected results:
+-----------------------------+
| Para 1.                     |
|             +--------------+|
|             |       |      ||
|             +--------------+|
|             |       |      ||
|             +--------------+|
| Para 2.                     |
+-----------------------------+

Actual results:
+-----------------------------+
| Para 1.                     |
| Para 2.     +--------------+|
|             |       |      ||
|             +--------------+|
|             |       |      ||
|             +--------------+|
+-----------------------------+

That's most probably the reason why HTML handles the situation the way we have it currently in the editor.

So, in a mixed content environment, I would just leave it as is, leaving the alignment option to the user. Any other alignment solution would not be compatible with the features we have in the table dialog currently.

Thoughts?

comment:2 Changed 9 years ago by Damian

Ok, I understand the problem, and it seems valid to me.

Perhaps what we should do here is check to see if a table already has an alignment set, and reverse it if it does. If there is no alignment on the table, we should leave it up to the user to set the alignment.

How does that sound?

comment:3 in reply to:  2 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: wontfix
Status: newclosed

Replying to damo:

How does that sound?

The right ticket for it is #6043. I've opened a discussion there.

comment:4 Changed 9 years ago by Damian

Considering that #6043 does not address table alignment. Is there anything we can do about tables here?

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy