Opened 9 years ago

Closed 9 years ago

#6046 closed Bug (fixed)

[3.4.x] Some form elements no longer have their context menu buttons

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Cc:

Description (last modified by Sa'ar Zac Elias)

  • Open a sample.
  • Add a image button.
  • Right click on it.

Notice that the "Image Button" option is missing.

The same happens for textarea, text input, radio button and checkbox.

Attachments (1)

6046.patch (1.2 KB) - added by Sa'ar Zac Elias 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Sa'ar Zac Elias

Description: modified (diff)
Summary: [3.4.x] Image button no longer has it's button in the context menu[3.4.x] Some form elements no longer have their context menu buttons

comment:2 Changed 9 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: newassigned

We should check if the input is readonly by request or it became readonly by our code to prevent it's editing.

Changed 9 years ago by Sa'ar Zac Elias

Attachment: 6046.patch added

comment:3 Changed 9 years ago by Sa'ar Zac Elias

Status: assignedreview

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

The change makes a lot of sense.

Before committing, please take the following in consideration:

  • Let's just make the fix more generic, so it can be used for any need. Instead of calling the marker "_cke_lockedInput", let's name it "cke_notReadOnly".
  • Also, usually for such flags, we use "1", instead of "true", to save 3 bytes of code size :)

comment:5 Changed 9 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [5781].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy