Opened 14 years ago
Closed 14 years ago
#6046 closed Bug (fixed)
[3.4.x] Some form elements no longer have their context menu buttons
Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4 |
Component: | General | Version: | SVN (CKEditor) - OLD |
Keywords: | Cc: |
Description (last modified by )
- Open a sample.
- Add a image button.
- Right click on it.
Notice that the "Image Button" option is missing.
The same happens for textarea, text input, radio button and checkbox.
Attachments (1)
Change History (6)
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Summary: | [3.4.x] Image button no longer has it's button in the context menu → [3.4.x] Some form elements no longer have their context menu buttons |
comment:2 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | new → assigned |
Changed 14 years ago by
Attachment: | 6046.patch added |
---|
comment:3 Changed 14 years ago by
Status: | assigned → review |
---|
comment:4 Changed 14 years ago by
Status: | review → review_passed |
---|
The change makes a lot of sense.
Before committing, please take the following in consideration:
- Let's just make the fix more generic, so it can be used for any need. Instead of calling the marker "_cke_lockedInput", let's name it "cke_notReadOnly".
- Also, usually for such flags, we use "1", instead of "true", to save 3 bytes of code size :)
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5781].
We should check if the input is readonly by request or it became readonly by our code to prevent it's editing.