Opened 9 years ago

Last modified 9 years ago

#6076 confirmed Bug

[IE Quirks] Dialogs are not wide enough for their contents / Templates Dialog

Reported by: Charlie Owned by:
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.4.1
Keywords: IE HasPatch Cc:

Description

I've build a couple custom plugins now and keep running into the problem that the windows never seem to stretch to accomodate the content. Thus I have to very carefully set the minWidth correctly in the dialog definition.

I thought this was my fault until I came to the templates dialog. In SVN, the templates container is also not wide enough for the contents. To replicate, pop open IE in quirks and open the templates dialog.

There are two possible fixes for this (or both): 1) Define the templates dialog as being bigger 2) Rollback #4863 - if you change dialog.css .cke_skin_kama .cke_browser_iequirks .cke_dialog_page_contents and set position = relative (or just remove it)...the dialogs will accomodate the content better.

There might be another fix which is making the templates scroll contents better styled, because right now it looks like there is excessive whitespace in there serving no purpose. But even when I managed to make that box smaller, the intro text above it still runs over. Thoughts?

Attachments (2)

template_size_error.JPG (53.6 KB) - added by Charlie 9 years ago.
6076.patch (1.1 KB) - added by Charlie 9 years ago.
Fix Idea #1

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Status: newpending

I'm not seeing any problem with the templates dialog. I'm testing it with IE8+Quirks and even with IE6.

Do you have a screenshot of it, and maybe some extra information?

Changed 9 years ago by Charlie

Attachment: template_size_error.JPG added

comment:2 Changed 9 years ago by Charlie

Version: SVN (CKEditor) - OLD3.4.1 (SVN - trunk)

To reproduce open up IE in quirks mode. Then open the Templates dialog... I've done it on multiple computers with both demo site and nightly build.

It's a standard bug with dialogs in general. If you make the dialog width too small in the dialogDefinition, it looks like the content will shrink (or the dialog grows?) in all other browsers, but in quirks it simply runs over the dialog as shown in the attached picture.

For another example, you can look at the Iframe Dialog I posted earlier, one of the earlier versions had it defined too small so the text ran over in Quirks.

The "simple" fix is to change:

minWidth : CKEDITOR.env.ie ? 440 : 400,

to

minWidth : CKEDITOR.env.ie ? 540 : 400,

But since it is defined as "minWidth" the box should really be growing to fit the content...

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Status: pendingconfirmed

A picture is worth a thousand words... it's not enough opening the Template dialog. The problem here is the long label above the selection box, which in English is not a long as the German one (not a surprise, right? :)).

Changed 9 years ago by Charlie

Attachment: 6076.patch added

Fix Idea #1

comment:4 Changed 9 years ago by Charlie

Keywords: HasPatch added

Let me know what you think of the patch. I let it apply itself to all browsers because I think that it looks much better (in working browsers) and more clean than the line just running on forever and creating ultra-wide dialogs.

As for IE Quirks, it doesn't create a line-break anywhere, but it does force the dialog to expand to fit it. Not totally ideal, but it make the error less obvious.

Since there wasn't a ui_html definition before, I think this shouldn't break anything. Is there ever a case where one wouldn't want the element to wrap? I can't think of one so should be fine.

Hope it works

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy