Opened 10 years ago

Last modified 9 years ago

#6091 review_failed Bug

Inserting pagebreak inside some text in a list item breaks the item

Reported by: Sa'ar Zac Elias Owned by: Martin
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

  • Load the following html and place the caret as marked:
    <ol><li>Lorem ^ipsum</li></ol>
    
  • Click on the Page break icon.

Notice that the item is splitted into two different items.

Attachments (2)

#6091.patch (609 bytes) - added by Martin 10 years ago.
Patch
6091_2.patch (2.1 KB) - added by Martin 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Status: newconfirmed

Changed 10 years ago by Martin

Attachment: #6091.patch added

Patch

comment:2 Changed 10 years ago by Martin

Owner: set to Martin
Status: confirmedreview

comment:3 Changed 10 years ago by Tobiasz Cudnik

Status: reviewreview_failed

Patched method splitBlock from range.js doesn't seem to be right place for fixing pagebreak issues. Rather you should do those checks in place where method is invoked.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

toLowwerCase??? has this code ever been tested?

Additionally, getName() already normalizes the names to lowercase, so there is no need to do that.

Changed 10 years ago by Martin

Attachment: 6091_2.patch added

comment:5 Changed 10 years ago by Martin

Status: review_failedreview

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

This patch needs to be updated to the current trunk and its overall quality enhanced.

comment:7 Changed 9 years ago by Jakub Ś

When fixing this issue please also have a look at #8915 as there might be one solution for those two.

Note: See TracTickets for help on using tickets.
© 2003 – 2020 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy