Opened 14 years ago
Last modified 13 years ago
#6091 review_failed Bug
Inserting pagebreak inside some text in a list item breaks the item
| Reported by: | Sa'ar Zac Elias | Owned by: | Martin |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
- Load the following html and place the caret as marked:
<ol><li>Lorem ^ipsum</li></ol>
- Click on the Page break icon.
Notice that the item is splitted into two different items.
Attachments (2)
Change History (9)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
Changed 14 years ago by
| Attachment: | #6091.patch added |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Martin |
|---|---|
| Status: | confirmed → review |
comment:3 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Patched method splitBlock from range.js doesn't seem to be right place for fixing pagebreak issues. Rather you should do those checks in place where method is invoked.
comment:4 Changed 14 years ago by
toLowwerCase??? has this code ever been tested?
Additionally, getName() already normalizes the names to lowercase, so there is no need to do that.
Changed 14 years ago by
| Attachment: | 6091_2.patch added |
|---|
comment:5 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:6 Changed 13 years ago by
| Status: | review → review_failed |
|---|
This patch needs to be updated to the current trunk and its overall quality enhanced.
comment:7 Changed 13 years ago by
When fixing this issue please also have a look at #8915 as there might be one solution for those two.
Note: See
TracTickets for help on using
tickets.
Patch