Opened 14 years ago

Closed 14 years ago

#6109 closed Task (fixed)

use commitContent() and setupContent() methods in pastetext plugin dialog

Reported by: Frank Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.5.4
Component: General Version:
Keywords: Cc: frank@…

Description

We are currently integrating CKEditor into ExtJS.

There seems to be a standard pattern for separation of concerns between user interface and data layer.

When a CKEditor shows a dialog data is normally set via the setupContent() method, on okay data is normally stored via the commitContent() method. The pastetext plugin dialog does not follow this pattern. To be reusable in our/ other integrations it should follow this standard pattern.

Find a patch for the ckeditor/_source/plugins/pastetext/dialogs/pastetext.js file attached.

Attachments (3)

patchfile.patch (480 bytes) - added by Frank 14 years ago.
6109.patch (2.8 KB) - added by Sa'ar Zac Elias 14 years ago.
6109_2.patch (8.3 KB) - added by Sa'ar Zac Elias 14 years ago.

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by Frank

Attachment: patchfile.patch added

comment:1 Changed 14 years ago by Frank

Cc: frank@… added

Any news on this?

comment:2 Changed 14 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.5.4
Owner: set to Sa'ar Zac Elias
Status: newassigned
Version: 3.4 Beta

Changed 14 years ago by Sa'ar Zac Elias

Attachment: 6109.patch added

comment:3 Changed 14 years ago by Sa'ar Zac Elias

Status: assignedreview

comment:4 Changed 14 years ago by Garry Yao

Status: reviewreview_failed

I don't think the patch achieve the purpose of this ticket, while we expect dialog fields data are populated/collected via setupContent/commitContent, which means, the paste area should have the corresponding setup/commit method to do the job, this make it possible to overwrite the original method for customization, e.g.

Changed 14 years ago by Sa'ar Zac Elias

Attachment: 6109_2.patch added

comment:5 Changed 14 years ago by Sa'ar Zac Elias

Status: review_failedreview_passed

comment:6 Changed 14 years ago by Frederico Caldeira Knabben

:/ aren't we missing the review here?

comment:7 Changed 14 years ago by Sa'ar Zac Elias

Status: review_passedreview

Sorry, one button too low ;)

comment:8 Changed 14 years ago by Garry Yao

Status: reviewreview_passed

comment:9 Changed 14 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6799].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy