Opened 15 years ago
Closed 15 years ago
#6109 closed Task (fixed)
use commitContent() and setupContent() methods in pastetext plugin dialog
| Reported by: | Frank | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.4 |
| Component: | General | Version: | |
| Keywords: | Cc: | frank@… |
Description
We are currently integrating CKEditor into ExtJS.
There seems to be a standard pattern for separation of concerns between user interface and data layer.
When a CKEditor shows a dialog data is normally set via the setupContent() method, on okay data is normally stored via the commitContent() method. The pastetext plugin dialog does not follow this pattern. To be reusable in our/ other integrations it should follow this standard pattern.
Find a patch for the ckeditor/_source/plugins/pastetext/dialogs/pastetext.js file attached.
Attachments (3)
Change History (12)
Changed 15 years ago by
| Attachment: | patchfile.patch added |
|---|
comment:1 Changed 15 years ago by
| Cc: | frank@… added |
|---|
comment:2 Changed 15 years ago by
| Milestone: | → CKEditor 3.5.4 |
|---|---|
| Owner: | set to Sa'ar Zac Elias |
| Status: | new → assigned |
| Version: | 3.4 Beta |
Changed 15 years ago by
| Attachment: | 6109.patch added |
|---|
comment:3 Changed 15 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 15 years ago by
| Status: | review → review_failed |
|---|
I don't think the patch achieve the purpose of this ticket, while we expect dialog fields data are populated/collected via setupContent/commitContent, which means, the paste area should have the corresponding setup/commit method to do the job, this make it possible to overwrite the original method for customization, e.g.
Changed 15 years ago by
| Attachment: | 6109_2.patch added |
|---|
comment:5 Changed 15 years ago by
| Status: | review_failed → review_passed |
|---|
comment:8 Changed 15 years ago by
| Status: | review → review_passed |
|---|
comment:9 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6799].
Any news on this?