Opened 7 years ago

Closed 6 years ago

#6111 closed Bug (fixed)

Splitting cell horizontally after splitting another vertically can cause incorrect colspans

Reported by: Evan Krall Owned by: Martin
Priority: Normal Milestone: CKEditor 3.6.3
Component: Core : Tables Version: 3.1
Keywords: Cc:

Description

Steps to reproduce:

  1. Create a 3x3 table
  2. Split vertically the third cell in the second row
  3. Split horizontally the second cell in the third row.

Expected: 4x4 table with some cells merged Actual: 2nd cell in 2nd row has colspan=3, causing the last cells in the 2nd and 3rd row to stick out the right side of the table.

Attachments (4)

ckeditor_tableproblems.PNG (12.4 KB) - added by Evan Krall 7 years ago.
Step-by-step instructions for reproduction
6111.patch (729 bytes) - added by Martin 7 years ago.
Patch
6111_2.patch (561 bytes) - added by Martin 7 years ago.
Patch
6111_3.patch (558 bytes) - added by Martin 7 years ago.

Download all attachments as: .zip

Change History (16)

Changed 7 years ago by Evan Krall

Attachment: ckeditor_tableproblems.PNG added

Step-by-step instructions for reproduction

comment:1 Changed 7 years ago by Wiktor Walc

Keywords: table colspan rowspan removed
Status: newconfirmed

Confirmed in IE8 and FF 3.6.8. I did not test other browsers.

comment:2 Changed 7 years ago by Martin

Owner: set to Martin
Status: confirmedassigned

Changed 7 years ago by Martin

Attachment: 6111.patch added

Patch

comment:3 Changed 7 years ago by Martin

Status: assignedreview

comment:4 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

Patch is OK, but coding style is wrong - please use tabs for indentation.

Besides this, nice fix :)

Changed 7 years ago by Martin

Attachment: 6111_2.patch added

Patch

Changed 7 years ago by Martin

Attachment: 6111_3.patch added

comment:5 Changed 7 years ago by Martin

Status: review_failedreview

comment:6 Changed 7 years ago by Wiktor Walc

Component: GeneralCore : Tables

comment:7 Changed 6 years ago by Krzysztof Studnik

related to #8177

comment:8 Changed 6 years ago by Jakub Ś

Version: 3.1

Issue has been reproducible from CKEditor 3.1

Related tickets are: #8666, #8177

comment:9 Changed 6 years ago by Jakub Ś

Keywords: HasPatch added

I did a quick test for patch 3 and it seems to fix the problem.

comment:10 Changed 6 years ago by Frederico Caldeira Knabben

comment:11 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.3
Status: reviewreview_passed

comment:12 Changed 6 years ago by Garry Yao

Keywords: HasPatch removed
Resolution: fixed
Status: review_passedclosed

Fixed with [7409].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy