Opened 7 years ago

Closed 7 years ago

#6137 closed Bug (fixed)

Table dialog: width doesn't have the default value on second open

Reported by: Frederico Caldeira Knabben Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: 3.4 Beta
Keywords: Cc:

Description

  1. Click the table button to create a new table. Note that the Width field presents the default "500" value.
  2. ESC to close the dialog.
  3. Click the table button again.

The Width field will be blank.

Works well with CKEditor 3.3.2.

Attachments (3)

6137.patch (833 bytes) - added by Sa'ar Zac Elias 7 years ago.
6137_2.patch (5.0 KB) - added by Garry Yao 7 years ago.
6137_3.patch (5.7 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: newassigned

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6137.patch added

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Status: assignedreview

comment:3 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

The patch provide a workaround for this particular field while it's still buggy when you have, e.g. a default table height.

Changed 7 years ago by Garry Yao

Attachment: 6137_2.patch added

comment:4 Changed 7 years ago by Garry Yao

The patch is proposing the following change:

No 'change' event during internal fields committing and when fields resetting.

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

#6148 has been marked as DUP.

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

It's great seeing you here Garry.

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The change in the reset method causes problems with manual resetting.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6137_3.patch added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:9 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:10 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [5822].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy