Opened 7 years ago

Closed 7 years ago

#6138 closed Bug (fixed)

List indentation is not working

Reported by: Frederico Caldeira Knabben Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.1
Component: Core : Lists Version: 3.3.2
Keywords: IBM Cc: damian.chojna@…

Description

  1. Load this HTML:
<ul>
	<li>Line 1</li>
	<li>Line 2</li>
</ul>
  1. CTRL+A to select all.
  2. Click the "Decrease Indentation" button.

The list will not be removed, and the items contents will be now inside <p> elements.

We have the same issue when using "Increase Indentation" on step 3, having the indentation being applied to the new <p> instead of the <ul>.

Attachments (2)

6138.patch (920 bytes) - added by Tobiasz Cudnik 7 years ago.
6138_2.patch (881 bytes) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6138.patch added

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

It's R+ for me, but it looks like you forgot putting it on review.

Be sure to open a ticket for Firebug before committing, as we should not have such "_firebugConsole" checks in the code.

comment:3 Changed 7 years ago by Damian

Cc: damian.chojna@… added
Keywords: IBM added

comment:4 in reply to:  2 Changed 7 years ago by Sa'ar Zac Elias

Replying to fredck:

Be sure to open a ticket for Firebug before committing, as we should not have such "_firebugConsole" checks in the code.

The issue was already reported by Garry as issue 2960 and has been fixed in Firebug 1.6a9.

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6138_2.patch added

comment:5 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

Indeed i forgot to put it on a review, sorry. I've removed Firebug related code in second patch and updated bookmarks to new prefix (cke).

comment:6 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: review_passedreview_failed

I can still reproduce the bug in FF.

comment:8 Changed 7 years ago by Tobiasz Cudnik

Status: review_failedreview

You need to disable firebug prior to version 1.6 to have it working.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:10 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [5842].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy