Ticket #6199 (closed New Feature: wontfix)

Opened 4 years ago

Last modified 13 months ago

Tool to convert v2 template files to v3

Reported by: fredck Owned by:
Priority: Normal Milestone:
Component: General Version: 3.4.1
Keywords: Cc:

Description

While we don't have a plugin to load XML for templates (a la v2) (see #3588), we should at least provide a tool that makes it easier to convert old v2 templates to the new js v3 format.

Attachments

6199.patch (5.7 KB) - added by fredck 4 years ago.
6199_2.patch (5.8 KB) - added by fredck 4 years ago.

Change History

Changed 4 years ago by fredck

comment:1 Changed 4 years ago by fredck

  • Status changed from new to review

This is a first proposal for this tool. We could keep it on the _dev folder, and also make it available in a public address so the documentation can point to it and users would be able to use it online as well.

comment:2 Changed 4 years ago by fredck

Note that this patch depends on #6197.

comment:3 Changed 4 years ago by garry.yao

  • Keywords Discuss added

Vote for delivering such utility as dev script instead of web pages.

comment:4 Changed 4 years ago by fredck

  • Keywords Discussion added; Discuss removed

-1 to have it as dev script:

  • It would be harder for people to use it.
  • It would not be possible to have it as a page on the web, reachable by everybody, independent on the platform.

This is a first proposal. A script tool could be also considered in the future, but there is no reason to block this one because of this, considering that it has been already fully developed.

comment:5 Changed 4 years ago by Saare

  • Status changed from review to review_failed

I also think this tool should not be a dev script.
Well I don't see any problems with the converter, just a bit of cosmetic:

  • It'll be a good idea to fill the <title> tag.
  • If the XML is invalid, the thrown message is The <Templates> node was not found. IMHO it should be something like "The XML file is not valid.".

Changed 4 years ago by fredck

comment:6 Changed 4 years ago by fredck

  • Keywords Discussion removed
  • Status changed from review_failed to review

The new patch has the <title> element filled.

The original XML error, sent from the parser, is still there, because it can help understand what exactly is wrong, instead of a generic message. I've changed the message a bit.

comment:7 Changed 4 years ago by garry.yao

  • Milestone changed from CKEditor 3.4.2 to CKEditor 3.5

comment:8 Changed 3 years ago by garry.yao

  • Status changed from review to review_failed
  1. JS string output are not properly escaped, e.g. line break and single quote;
  2. Browser compatibility, breaks in IE9 actually

The reason I don't like ad-hoc script also because the structure (formatting and semantic) are entirely hard encoded and thus would bring a maintenance issue later.

Finally, the reason that I don't like browser's XML API is that it's way complicated to code when comparing with a server-side version of the same functionality.

comment:9 Changed 3 years ago by fredck

  • Status changed from review_failed to new
  • Owner fredck deleted
  • Milestone CKEditor 3.5 deleted

@Garry, at your choice, we'll be delivering anything to our users at this time so. Please feel free the take the ticket ownership anytime in the future.

comment:10 Changed 13 months ago by fredck

  • Status changed from new to closed
  • Resolution set to wontfix

If anyone is still interested in this feature, please feel free to reopen this ticket and provide a possible solution for it.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy