Opened 14 years ago
Closed 12 years ago
#6199 closed New Feature (wontfix)
Tool to convert v2 template files to v3
| Reported by: | Frederico Caldeira Knabben | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | 3.4.1 |
| Keywords: | Cc: |
Description
While we don't have a plugin to load XML for templates (a la v2) (see #3588), we should at least provide a tool that makes it easier to convert old v2 templates to the new js v3 format.
Attachments (2)
Change History (12)
Changed 14 years ago by
| Attachment: | 6199.patch added |
|---|
comment:1 Changed 14 years ago by
| Status: | new → review |
|---|
comment:3 Changed 14 years ago by
| Keywords: | Discuss added |
|---|
Vote for delivering such utility as dev script instead of web pages.
comment:4 Changed 14 years ago by
| Keywords: | Discussion added; Discuss removed |
|---|
-1 to have it as dev script:
- It would be harder for people to use it.
- It would not be possible to have it as a page on the web, reachable by everybody, independent on the platform.
This is a first proposal. A script tool could be also considered in the future, but there is no reason to block this one because of this, considering that it has been already fully developed.
comment:5 Changed 14 years ago by
| Status: | review → review_failed |
|---|
I also think this tool should not be a dev script.
Well I don't see any problems with the converter, just a bit of cosmetic:
- It'll be a good idea to fill the <title> tag.
- If the XML is invalid, the thrown message is
The <Templates> node was not found. IMHO it should be something like "The XML file is not valid.".
Changed 14 years ago by
| Attachment: | 6199_2.patch added |
|---|
comment:6 Changed 14 years ago by
| Keywords: | Discussion removed |
|---|---|
| Status: | review_failed → review |
The new patch has the <title> element filled.
The original XML error, sent from the parser, is still there, because it can help understand what exactly is wrong, instead of a generic message. I've changed the message a bit.
comment:7 Changed 14 years ago by
| Milestone: | CKEditor 3.4.2 → CKEditor 3.5 |
|---|
comment:8 Changed 14 years ago by
| Status: | review → review_failed |
|---|
- JS string output are not properly escaped, e.g. line break and single quote;
- Browser compatibility, breaks in IE9 actually
The reason I don't like ad-hoc script also because the structure (formatting and semantic) are entirely hard encoded and thus would bring a maintenance issue later.
Finally, the reason that I don't like browser's XML API is that it's way complicated to code when comparing with a server-side version of the same functionality.
comment:9 Changed 14 years ago by
| Milestone: | CKEditor 3.5 |
|---|---|
| Owner: | Frederico Caldeira Knabben deleted |
| Status: | review_failed → new |
@Garry, at your choice, we'll be delivering anything to our users at this time so. Please feel free the take the ticket ownership anytime in the future.
comment:10 Changed 12 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
If anyone is still interested in this feature, please feel free to reopen this ticket and provide a possible solution for it.
This is a first proposal for this tool. We could keep it on the _dev folder, and also make it available in a public address so the documentation can point to it and users would be able to use it online as well.