#6200 closed Bug (fixed)
No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.2 |
Component: | UI : Dialogs | Version: | |
Keywords: | IBM | Cc: | Damian, joek |
Description
To reproduce the defect:
- Open Ajax sample.
- Click on Find and Replace Icon & Flash icons in the Tool bar to activate Find and Replace & Flash Properties dialogs.
- When dialogs are opened tab through each element to see if the focus is shown properly for all the elements when we are tabbing through them
Focus not shown for Check boxes on both Find and Replace tabs of Find and Replace dialog.
Focus not shown for Check boxes on Properties tabs of Flash Properties dialog.
In IE6 focus is shown around the label for the Check box instead of showing it on the Check box.
Attachments (7)
Change History (31)
comment:1 Changed 14 years ago by
Component: | General → UI : Dialogs |
---|---|
Status: | new → confirmed |
comment:2 Changed 14 years ago by
Milestone: | → CKEditor 3.6 |
---|
comment:3 Changed 14 years ago by
Owner: | set to Tobiasz Cudnik |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 14 years ago by
Owner: | Tobiasz Cudnik deleted |
---|---|
Status: | assigned → new |
comment:5 Changed 14 years ago by
Status: | new → confirmed |
---|
comment:6 Changed 14 years ago by
Milestone: | CKEditor 3.6 |
---|
Changed 14 years ago by
Attachment: | 6200.patch added |
---|
comment:7 Changed 14 years ago by
Cc: | damo,joek → damo, joek |
---|---|
Owner: | set to Sa'ar Zac Elias |
Status: | confirmed → review |
comment:8 Changed 14 years ago by
Status: | review → review_failed |
---|
- Ratio lock (Image dialog) requires the same fix;
- Other inputs in Firefox requires also such a fix, including checkbox, ration and select:
.cke_skin_kama .cke_browser_gecko .cke_dialog_ui_checkbox_input:focus, .cke_skin_kama .cke_browser_gecko .cke_dialog_ui_input_select:focus { outline:#696969 dotted 1px; }
comment:9 Changed 14 years ago by
Summary: | IE 7 - No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs → No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs |
---|
Update ticket as it's not an IE specific issue.
Changed 14 years ago by
Attachment: | 6200_2.patch added |
---|
comment:10 Changed 14 years ago by
Status: | review_failed → review |
---|
Changed 14 years ago by
Attachment: | 6200_3.patch added |
---|
comment:11 Changed 14 years ago by
Owner: | changed from Sa'ar Zac Elias to Garry Yao |
---|
Previous patch contains some unnecessary changes, besides, ratio is subjected to the fix also.
comment:12 Changed 14 years ago by
Status: | review → review_failed |
---|
The patch doesn't bring any change at all.
Changed 14 years ago by
Attachment: | 6200_4.patch added |
---|
comment:13 Changed 14 years ago by
Status: | review_failed → review |
---|
comment:14 Changed 14 years ago by
Status: | review → review_failed |
---|
In NATIVE IE6, there are now borders around checkboxes and the ratio images.
comment:15 Changed 13 years ago by
#8013 is a dup.
Note: Select boxes are also to be considered in FF.
Changed 13 years ago by
Attachment: | 6200_5.patch added |
---|
comment:16 Changed 13 years ago by
Status: | review_failed → review |
---|
The patch takes care of the IE6 fake border issue.
comment:17 Changed 13 years ago by
Status: | review → review_failed |
---|
Problem's still not solved in Opera.
Changed 13 years ago by
Attachment: | 6200_6.patch added |
---|
comment:18 Changed 13 years ago by
Status: | review_failed → review |
---|
Ok...now have Opera included into the fixes.
comment:19 Changed 13 years ago by
Status: | review → review_failed |
---|
Seems like the patch has no effect at all in IE6-7 now.
Changed 13 years ago by
Attachment: | 6200_7.patch added |
---|
comment:20 Changed 13 years ago by
Status: | review_failed → review |
---|
comment:21 Changed 13 years ago by
Status: | review → review_passed |
---|
comment:22 Changed 13 years ago by
Milestone: | → CKEditor 3.6.2 |
---|
comment:23 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7222].
comment:24 Changed 13 years ago by
The patch did not fixed the Visual Focus issue in High contrast mode. In High Contrast mode, we are not seeing Visual Focus when we tab to Check boxes & list boxes on all dialogs.
Please re open this ticket
I think it's better us having custom styling for focused checkboxes in the dialogs, instead of relaying on the browser default thing.