Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#6200 closed Bug (fixed)

No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: UI : Dialogs Version:
Keywords: IBM Cc: Damian, joek

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Click on Find and Replace Icon & Flash icons in the Tool bar to activate Find and Replace & Flash Properties dialogs.
  1. When dialogs are opened tab through each element to see if the focus is shown properly for all the elements when we are tabbing through them

Focus not shown for Check boxes on both Find and Replace tabs of Find and Replace dialog.

Focus not shown for Check boxes on Properties tabs of Flash Properties dialog.

In IE6 focus is shown around the label for the Check box instead of showing it on the Check box.

Attachments (7)

6200.patch (3.3 KB) - added by Sa'ar Zac Elias 6 years ago.
6200_2.patch (9.0 KB) - added by Sa'ar Zac Elias 6 years ago.
6200_3.patch (2.2 KB) - added by Garry Yao 6 years ago.
6200_4.patch (4.8 KB) - added by Garry Yao 6 years ago.
6200_5.patch (4.2 KB) - added by Garry Yao 6 years ago.
6200_6.patch (4.8 KB) - added by Garry Yao 6 years ago.
6200_7.patch (5.8 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (31)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Dialogs
Status: newconfirmed

I think it's better us having custom styling for focused checkboxes in the dialogs, instead of relaying on the browser default thing.

comment:2 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.6

comment:3 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

comment:4 Changed 6 years ago by Frederico Caldeira Knabben

Owner: Tobiasz Cudnik deleted
Status: assignednew

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: newconfirmed

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 6200.patch added

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Cc: damo,joekdamo, joek
Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:8 Changed 6 years ago by Garry Yao

Status: reviewreview_failed
  • Ratio lock (Image dialog) requires the same fix;
  • Other inputs in Firefox requires also such a fix, including checkbox, ration and select:
    .cke_skin_kama .cke_browser_gecko .cke_dialog_ui_checkbox_input:focus,
    .cke_skin_kama .cke_browser_gecko .cke_dialog_ui_input_select:focus
    {
    	outline:#696969 dotted 1px;
    }
    

comment:9 Changed 6 years ago by Garry Yao

Summary: IE 7 - No Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogsNo Visual Focus when we tab to Check boxes on Find and Replace & Flash Properties dialogs

Update ticket as it's not an IE specific issue.

Changed 6 years ago by Sa'ar Zac Elias

Attachment: 6200_2.patch added

comment:10 Changed 6 years ago by Sa'ar Zac Elias

Status: review_failedreview

Changed 6 years ago by Garry Yao

Attachment: 6200_3.patch added

comment:11 Changed 6 years ago by Garry Yao

Owner: changed from Sa'ar Zac Elias to Garry Yao

Previous patch contains some unnecessary changes, besides, ratio is subjected to the fix also.

comment:12 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The patch doesn't bring any change at all.

Changed 6 years ago by Garry Yao

Attachment: 6200_4.patch added

comment:13 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:14 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

In NATIVE IE6, there are now borders around checkboxes and the ratio images.

comment:15 Changed 6 years ago by Sa'ar Zac Elias

#8013 is a dup.
Note: Select boxes are also to be considered in FF.

Last edited 6 years ago by Sa'ar Zac Elias (previous) (diff)

Changed 6 years ago by Garry Yao

Attachment: 6200_5.patch added

comment:16 Changed 6 years ago by Garry Yao

Status: review_failedreview

The patch takes care of the IE6 fake border issue.

comment:17 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Problem's still not solved in Opera.

Changed 6 years ago by Garry Yao

Attachment: 6200_6.patch added

comment:18 Changed 6 years ago by Garry Yao

Status: review_failedreview

Ok...now have Opera included into the fixes.

comment:19 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Seems like the patch has no effect at all in IE6-7 now.

Changed 6 years ago by Garry Yao

Attachment: 6200_7.patch added

comment:20 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:21 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:22 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.2

comment:23 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7222].

comment:24 Changed 6 years ago by Satya Minnekanti

The patch did not fixed the Visual Focus issue in High contrast mode. In High Contrast mode, we are not seeing Visual Focus when we tab to Check boxes & list boxes on all dialogs.

Please re open this ticket

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy