Opened 9 years ago

Closed 9 years ago

#6206 closed Bug (invalid)

Image plugin not taking filebrowserImageBrowseUrl as an argument

Reported by: Tony Owned by:
Priority: Normal Milestone:
Component: General Version: 3.4
Keywords: invalid Cc:

Description

This patch follows up on this : http://dev.ckeditor.com/ticket/4987 bug, which is related to these : http://dev.ckeditor.com/changeset/5096 changes and adapts the image plugin to use editor.config.filebrowserImageBrowseUrl in the same way as editor.config.filebrowserImageBrowseLinkUrl is being used.

When following the docs : http://docs.cksource.com/CKEditor_3.x/Developers_Guide/File_Browser_(Uploader) editor.config.filebrowserImageBrowseUrl does work as expected in the image plugin and is used for the browse button but after some customising of the image plugin I realised that editor.config.filebrowserImageBrowseUrl wasn't being used by the plugin itself, rather some other core 'Magic' was selecting editor.config.filebrowserImageBrowseUrl instead of filebrowserBrowseUrl (For the browse button on the image dialog not the browse button on the link tab of the image dialog.)

So here's a small patch for editor.config.filebrowserImageBrowseUrl in the image plugin's image.js file which replicates the way that config.filebrowserImageBrowseLinkUrl is used in the same plugin. The patch starts at line 571 and the method was adapted from line 1,127 in the same file.

Attachments (1)

image-plugin-filebrowserImageBrowseUrl.patch (326 bytes) - added by Tony 9 years ago.
Image plugin filebrowserImageBrowseUrl patch

Download all attachments as: .zip

Change History (2)

Changed 9 years ago by Tony

Image plugin filebrowserImageBrowseUrl patch

comment:1 Changed 9 years ago by Tony

Keywords: invalid added
Resolution: invalid
Status: newclosed

Scratch that, I've just realised that the patch conflicts with existing "Logic" In the image plugin and the filebrowser plugin. The other core 'Magic' I've realised is that editor.config.filebrowserImageBrowseUrl can just as easily be editor.config.filebrowserSomeImageBrowseUrl if the plugin is called SomeImage or someImage. Marked as invalid. The patch doesn't work and switches to the link tab instead.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy