#6226 closed Bug (fixed)
BIDI: Language direction applied to a Paragraph is removed when we apply one of Paragraph formatting options
| Reported by: | Satya Minnekanti | Owned by: | Paweł Horzela |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | General | Version: | 3.4 |
| Keywords: | IBM | Cc: | Damian, joek, jamcunni@… |
Description
To reproduce the defect:
- Open Ajax sample.
- Type a Paragraph & apply RTL Language direction to the Paragraph.
- Select the Paragraph and apply one of the Paragraph Formatting options(for ex: Heading 1) in Paragraph Format drop down list.
Expected Result:
selected Paragraph format(Heading 1) is applied to the Paragraph & language direction of the Paragraph still remains the same(RTL).
Actual Result:
selected Paragraph format(Heading 1) is applied to the Paragraph but language direction applied to Paragraph(RTL) is removed.
same behavior happens when we apply LTR direction to a Paragraph & apply Paragraph format option to the Paragraph
Attachments (3)
Change History (20)
comment:1 Changed 14 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 14 years ago by
| Owner: | set to Paweł Horzela |
|---|---|
| Status: | confirmed → assigned |
Changed 14 years ago by
| Attachment: | 6226.patch added |
|---|
comment:3 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Let's make the change more generic, copying all attributes from the original block.
comment:5 Changed 14 years ago by
| Milestone: | → CKEditor 3.4.2 |
|---|
comment:6 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:7 Changed 14 years ago by
| Cc: | jamcunni@… added |
|---|
comment:8 Changed 14 years ago by
| Status: | review → review_failed |
|---|
The change should only affect the bidi plugin, as it now ruins block styling.
comment:9 Changed 14 years ago by
Sorry, my bad - I didn't understand the ticket correctly. But still the attributes should be copied before the new attributes are being applied, so the new ones will dominate.
comment:10 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:11 Changed 14 years ago by
| Status: | review → review_passed |
|---|
Nice done, while be sure to rename 'block' to more generic 'element' before commit.
comment:12 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [5942]
comment:14 Changed 14 years ago by
What build can you check this fix on? The defect is still present on this build: http://nightly.ckeditor.com/5963/_samples/ajax.html
comment:15 Changed 14 years ago by
This defect has not been fixed. Is it possible to reopen this ticket?
comment:17 Changed 14 years ago by
[5942] has been mistaken reverted from trunk, now it comes back with [6000:6001].
Patch