Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6226 closed Bug (fixed)

BIDI: Language direction applied to a Paragraph is removed when we apply one of Paragraph formatting options

Reported by: Satya Minnekanti Owned by: Paweł Horzela
Priority: Normal Milestone: CKEditor 3.4.2
Component: General Version: 3.4
Keywords: IBM Cc: Damian, joek, jamcunni@…

Description

To reproduce the defect:

  1. Open Ajax sample.
  1. Type a Paragraph & apply RTL Language direction to the Paragraph.
  1. Select the Paragraph and apply one of the Paragraph Formatting options(for ex: Heading 1) in Paragraph Format drop down list.

Expected Result:

selected Paragraph format(Heading 1) is applied to the Paragraph & language direction of the Paragraph still remains the same(RTL).

Actual Result:

selected Paragraph format(Heading 1) is applied to the Paragraph but language direction applied to Paragraph(RTL) is removed.

same behavior happens when we apply LTR direction to a Paragraph & apply Paragraph format option to the Paragraph

Attachments (3)

6226.patch (527 bytes) - added by Paweł Horzela 7 years ago.
Patch
6226_2.patch (424 bytes) - added by Paweł Horzela 7 years ago.
Patch
6226_3.patch (915 bytes) - added by Paweł Horzela 7 years ago.
Patch

Download all attachments as: .zip

Change History (20)

comment:1 Changed 7 years ago by Paweł Horzela

Status: newconfirmed

comment:2 Changed 7 years ago by Paweł Horzela

Owner: set to Paweł Horzela
Status: confirmedassigned

Changed 7 years ago by Paweł Horzela

Attachment: 6226.patch added

Patch

comment:3 Changed 7 years ago by Paweł Horzela

Status: assignedreview

comment:4 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Let's make the change more generic, copying all attributes from the original block.

comment:5 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.4.2

Changed 7 years ago by Paweł Horzela

Attachment: 6226_2.patch added

Patch

comment:6 Changed 7 years ago by Paweł Horzela

Status: review_failedreview

comment:7 Changed 7 years ago by James

Cc: jamcunni@… added

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The change should only affect the bidi plugin, as it now ruins block styling.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Sorry, my bad - I didn't understand the ticket correctly. But still the attributes should be copied before the new attributes are being applied, so the new ones will dominate.

Changed 7 years ago by Paweł Horzela

Attachment: 6226_3.patch added

Patch

comment:10 Changed 7 years ago by Paweł Horzela

Status: review_failedreview

comment:11 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

Nice done, while be sure to rename 'block' to more generic 'element' before commit.

comment:12 Changed 7 years ago by Paweł Horzela

Resolution: fixed
Status: review_passedclosed

Fixed with [5942]

comment:13 Changed 7 years ago by Sa'ar Zac Elias

Renaming as per @Garry's comment was done by @paho with [5943].

comment:14 Changed 7 years ago by James

What build can you check this fix on? The defect is still present on this build: http://nightly.ckeditor.com/5963/_samples/ajax.html

comment:15 Changed 7 years ago by James

This defect has not been fixed. Is it possible to reopen this ticket?

comment:16 Changed 7 years ago by Damian

This might be related to #6479

comment:17 Changed 7 years ago by Garry Yao

[5942] has been mistaken reverted from trunk, now it comes back with [6000:6001].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy