BIDI: Applying direction to multi-paragraph selection within a div

[Damian]

When selecting multiple paragraphs that reside inside a <div>, the direction attribute is being set on the parent <div> rather than the paragraphs.

<div>
  <p>Paragraph 1</p>
  <p>Paragraph 2</p>
</div>

The expectation is that the individual paragraphs get their direction attribute set.

[Tobiasz Cudnik]

This feature interferer with a logic responsible for matching one fully selected element. In this case it's DIV, but after selecting all cells of a table, then it would change direction on table only.

Do you need this feature only for paragraphs ? What about paragraphs inside a table cell ?

[Damian]

This is a good question.

To help understand the impact, is it possible to get a list of cases where this might apply? One other case I'm guessing that is similar is lists.

[Tobiasz Cudnik]

This is true for following elements:

• table
• ul
• ol
• blockquote
• div

When their children will be selected, direction will be applied to parent element. Ticket responsible for this is #5909.

[Satya Minnekanti]

Correct steps to reproduce the defect is:

<div>

<p>Paragraph 1</p>

<p>Paragraph 2</p>

<p>Paragraph 3</p>

<p>Paragraph 4</p>

</div>

Create 3 or more paragraphs inside a div and then select any 2 paragraphs and apply RTL direction to them.

Expected Result: RTL Language direction should be applied only to the selected 2 paragraphs.

Actual Result: RTL Language direction is applied to the whole div and RTL Language direction is applied to all the paragraphs.

[Garry Yao]

satya's provided test should at least be targeted.

[Tobiasz Cudnik]

Attached patch handles last Satya's TC, although it's a logic in opposite direction that main ticket's TC.

Anyway i would like to have some review on this one too.

[Garry Yao]

@Tobias, I don't know how the block grouping feature (when nested blocks exist, style applied to the root block instead of contents), but it's problematic, considering the following case when applying the 'RTL' style:

<div>
<p dir="ltr">Paragraph 1</p>
<p>Paragraph 2</p>
</div>

I propose removing the 'getFullySelected' logic and just let it be as the same way with alignment and indentation command.

[Tobiasz Cudnik]

It turns out that main problem for this ticket was the TC from the 7th comment, not feature which groups direction from it's parent to the container, i've updated the patch which seems to solve this particular issue.

[Garry Yao]

After the patch 'getFullySelected' stops working, because of the following line:

parent.$ != selectedElement

Should be instead:

parent.equals( selectedElement )

[Garry Yao]

Besides, we should not get confused by empty text nodes also:

if ( selectionStart.getIndex() > 0 || selectionStart.getIndex() + 1 < selectedElement.getChildCount() ) 

[Garry Yao]

Proposing here a simpler way of checking fully selected block.

[Tobiasz Cudnik]

Proposed patch seems to be a better approach. I would give R+ for it.

[Tobiasz Cudnik]

Fixed with [5977].