Opened 7 years ago

Closed 6 years ago

#6247 closed Bug (fixed)

Focus not returning to editor on drop down close

Reported by: Satya Minnekanti Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.1
Component: UI : Floating Panel Version: 3.4
Keywords: IBM Cc: Damian, joek

Description (last modified by Garry Yao)

To reproduce the defect:

  1. Open Ajax sample.
  1. Type some text,keep the cursor in the text,click on any of the drop down lists(Styles,Paragraph Format,Font Name,Font Size,Text Color & Background Color) to show list items.
  1. Click on the same drop down to make the list disappear.(don't select any of the list items).
  • Actual Result: The editor has not got focus.Try to type some text and it see it won't get typed.

Attachments (3)

krst 10.50.26 .avi (60.5 KB) - added by Krzysztof Studnik 7 years ago.
6247.patch (1.7 KB) - added by Garry Yao 6 years ago.
6247_2.patch (2.5 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 in reply to:  description Changed 7 years ago by Krzysztof Studnik

Keywords: IE added
Status: newconfirmed
Version: 3.4

Replying to satya:

First Error:

Cursor is shown in the drop down list

Confirmed

  1. Click on the same drop down to make the list disappear.(don't select any of the list items).

Second Error:

Cursor is visible in the editor but the editor has not got focus. Try to type some text and it see it won't get typed.

Confirmed. Second opened list - Cursor is disabled.

Changed 7 years ago by Krzysztof Studnik

Attachment: krst 10.50.26 .avi added

comment:2 Changed 7 years ago by Martin

Owner: set to Martin
Status: confirmedassigned

comment:3 Changed 7 years ago by Krzysztof Studnik

Second part of the ticket is moved to #6345

comment:4 Changed 7 years ago by Martin

I looking for solution to resolve first error and I find out that set focus on panel (in this situation drop down list) works good but there is problem because you must catch every click event and check if drop down list is open and set focus on them so I think that is not good solution but resolve problem.

If this could be help the #5667 cause the problem.

comment:5 Changed 7 years ago by Martin

Owner: Martin deleted
Status: assignednew

comment:6 Changed 7 years ago by Garry Yao

Keywords: IE removed
Priority: NormalLow
Status: newconfirmed

This's a generic problem, the focus was trapped inside the closed panel ;(

comment:7 Changed 7 years ago by Garry Yao

Some other misbehaved TCs that I think tightly related to this:

  1. Open the default sample page with FF;
  2. Click inside editor to give focus;
  3. Open the styles combo by mouse click;
  4. Press 'Esc' key to close the combo;
  • Expected Result: Panel closed with focus return to editor;
  • Actual Result: Focus return to toolbar.

The above TC though is surprisingly work in IE though.

In a summary, what need to do here:

  1. Where to return focus depending on from where combo is opened;
    • Return focus to toolbar in condition of "toolbarMode";
    • Return focus to editor otherwise;
  2. "Esc" and button click must behave consistently following 1.
  3. 1 and 2 must apply to other panel based drop down.

comment:8 Changed 7 years ago by Garry Yao

Description: modified (diff)
Summary: [[IE]] Cursor is still visible in the editor after the editor loses focus.[[IE]] Focus not returning to editor on drop down close

comment:9 Changed 7 years ago by Garry Yao

Description: modified (diff)
Summary: [[IE]] Focus not returning to editor on drop down closeFocus not returning to editor on drop down close

Description cleanup.

Changed 6 years ago by Garry Yao

Attachment: 6247.patch added

comment:10 Changed 6 years ago by Garry Yao

Cc: damo,joekdamo, joek
Component: GeneralUI : Floating Panel
Owner: set to Garry Yao
Status: confirmedreview

comment:11 Changed 6 years ago by Frederico Caldeira Knabben

Priority: LowNormal
Status: reviewreview_failed

Still not working for Safari and Opera.

Changed 6 years ago by Garry Yao

Attachment: 6247_2.patch added

comment:12 Changed 6 years ago by Garry Yao

Status: review_failedreview

Add Safari and Opera compatibility.

comment:13 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:14 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.1

comment:15 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6920].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy