Opened 9 years ago

Closed 8 years ago

#6329 closed Bug (fixed)

indent on list is not appropriate

Reported by: yiminghe Owned by:
Priority: Normal Milestone:
Component: Core : Lists Version: 3.4
Keywords: Cc:

Description (last modified by Tobiasz Cudnik)

  1. type three sentence
  2. outdent above line more than 3 times
  3. click ul button to make above <p> to ul,li
  4. inside the second li,click indent button

expected: see attachment expected.png

actual : see attachment 5.png

my solution:

pass li's attribute to its children, in list/plugin.js line 122:

for ( i = 0 ; i < item.contents.length ; i++ )
						currentListItem.append( item.contents[i].clone( true, true ) );

change to

for ( i = 0 ; i < item.contents.length ; i++ ){
						var ic=item.contents[i].clone( true, true );
                        if(currentListItem.type == CKEDITOR.NODE_DOCUMENT_FRAGMENT){
                            item.element.copyAttributes(ic);
                        }
                        currentListItem.append(ic);
                    }

Attachments (6)

1.png (12.4 KB) - added by yiminghe 9 years ago.
2.png (10.9 KB) - added by yiminghe 9 years ago.
3.png (10.1 KB) - added by yiminghe 9 years ago.
4.png (12.2 KB) - added by yiminghe 9 years ago.
5.png (11.2 KB) - added by yiminghe 9 years ago.
expected.png (1.1 KB) - added by yiminghe 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by yiminghe

Attachment: 1.png added

Changed 9 years ago by yiminghe

Attachment: 2.png added

Changed 9 years ago by yiminghe

Attachment: 3.png added

Changed 9 years ago by yiminghe

Attachment: 4.png added

Changed 9 years ago by yiminghe

Attachment: 5.png added

Changed 9 years ago by yiminghe

Attachment: expected.png added

comment:1 Changed 9 years ago by yiminghe

Component: GeneralCore : Lists
Keywords: list indent added
Version: 3.4

comment:2 Changed 9 years ago by Tobiasz Cudnik

Description: modified (diff)
Keywords: list indent removed
Status: newpending

Why do you think we should not inherit indentation when creating a list ? (step 2 to 3)

comment:3 Changed 9 years ago by Tobiasz Cudnik

Description: modified (diff)

comment:4 Changed 8 years ago by Jakub Ś

Resolution: fixed
Status: pendingclosed

I have checked the issue in latest CKEditor 3.6.2.

It seems that lists are working now just like @yiminghe expected

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy