#6408 closed Bug (fixed)
AutoGrow 24px too high on IE
Reported by: | Dinu | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.2 |
Component: | General | Version: | 3.4.2 |
Keywords: | IE | Cc: |
Description
On IE 7,8 the autogrow computed size is 24px too high; I've tracked it down to
newHeight = doc.getBody().$.scrollHeight + 24;
I don't know what that adjustment is for; I'm assuming it's to compensate for an eventual horizontal scrollbar, in which case:
- 24 is tentative, the scrollbars are not expected to have a certain size, so scrollbar height should be computed by other means
- only add height if a hrz scrollbar is actually present
- if additional height is added, schedule another resize to shrink editor back if scrollbars go away as result of the first resize; although it's counterintuitive (the horizontal scrollbar going away on a vertical resize, it's been known to happen)
I'll try to look some more at this and figure a way for myself
Attachments (3)
Change History (14)
comment:1 Changed 14 years ago by
Keywords: | IE added |
---|---|
Milestone: | → CKEditor 3.4.2 |
Status: | new → confirmed |
Version: | → 3.4 |
Changed 14 years ago by
Attachment: | 6408.patch added |
---|
comment:2 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | confirmed → review |
comment:3 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [5924].
comment:5 Changed 14 years ago by
Version: | 3.4 → 3.4.2 |
---|
Reopen: not fixed
Test: IE8/IE8 Standards, IE8 Compat/IE7 Standards
Problem:
CKEDITOR.env.ie&&CKEDITOR.env.quirks?0:24
Should (probably?) be the other way around:
CKEDITOR.env.ie&&CKEDITOR.env.quirks?24:0
Side comment:
According to http://msdn.microsoft.com/en-us/library/ms533687(VS.85).aspx compatMode is deprecated, use documentMode if available for quirks mode detection. Haven't tested, just a thought.
comment:7 Changed 14 years ago by
Test: IE8/IE8 Standards, IE8 Compat/IE7 Standards
It works for me for those modes, could you attach a screenshot/screencast?
Changed 14 years ago by
comment:8 Changed 14 years ago by
Done. Your written code does this: adds 0px if the browser IS in quirks mode and 24px if it's in standards mode. Shouldn't it be the other way around?
Changed 14 years ago by
Attachment: | 6408_2.patch added |
---|
comment:11 Changed 14 years ago by
Please avoid adding comments to fixed ticket, #7173 has been opened for all issues mentioned.
Confirmed on Quirks mode.