Opened 14 years ago
Closed 14 years ago
#6502 closed Task (fixed)
Remove IE6 image preloading
Reported by: | Garry Yao | Owned by: | Tobiasz Cudnik |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.5 |
Component: | General | Version: | |
Keywords: | IE | Cc: |
Description
Discovered in #6187, in case we can confirm that the following hack is enough to eliminate the IE6 background image duplicated requests bug, we should consider remove the preloader from core.
Attachments (3)
Change History (12)
comment:1 Changed 14 years ago by
Keywords: | IE added |
---|---|
Status: | new → confirmed |
comment:2 Changed 14 years ago by
Owner: | set to Tobiasz Cudnik |
---|---|
Status: | confirmed → assigned |
Changed 14 years ago by
Attachment: | 6502.patch added |
---|
comment:3 Changed 14 years ago by
Status: | assigned → review |
---|
comment:4 Changed 14 years ago by
Status: | review → review_failed |
---|
Can we include also imagecacher.js along with the "preload" definition in skin file?
Changed 14 years ago by
Attachment: | 6502_2.patch added |
---|
comment:5 Changed 14 years ago by
Status: | review_failed → review |
---|
We should also remove imagecacher.js and it's references in packager and loader files, which is what the second patch does.
comment:6 Changed 14 years ago by
Status: | review → review_failed |
---|
The "preload" definition in skin file is useless at the moment.
Changed 14 years ago by
Attachment: | 6502_3.patch added |
---|
comment:8 Changed 14 years ago by
Status: | review → review_passed |
---|
comment:9 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6100].
After checking IE6 using the released version, with both Fiddler and httpd log i cannot see any difference after the fix from #6187.
Path the removes preloader code completely, as it would be unnecessary bits and we can always go back to it by reverting the patch in the future.