Opened 16 years ago

Closed 16 years ago

#6502 closed Task (fixed)

Remove IE6 image preloading

Reported by: Garry Yao Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.5
Component: General Version:
Keywords: IE Cc:

Description

Discovered in #6187, in case we can confirm that the following hack is enough to eliminate the IE6 background image duplicated requests bug, we should consider remove the preloader from core.

Attachments (3)

6502.patch​ (2.7 KB) - added by Tobiasz Cudnik 16 years ago.
6502_2.patch​ (6.0 KB) - added by Tobiasz Cudnik 16 years ago.
6502_3.patch​ (6.6 KB) - added by Tobiasz Cudnik 16 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 16 years ago by Garry Yao

Keywords: IE added
Status: new → confirmed

comment:2 Changed 16 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmed → assigned

Changed 16 years ago by Tobiasz Cudnik

Attachment: 6502.patch​ added

comment:3 Changed 16 years ago by Tobiasz Cudnik

Status: assigned → review

After checking IE6 using the released version, with both Fiddler and httpd log i cannot see any difference after the fix from #6187.

Path the removes preloader code completely, as it would be unnecessary bits and we can always go back to it by reverting the patch in the future.

comment:4 Changed 16 years ago by Garry Yao

Status: review → review_failed

Can we include also imagecacher.js along with the "preload" definition in skin file?

Changed 16 years ago by Tobiasz Cudnik

Attachment: 6502_2.patch​ added

comment:5 Changed 16 years ago by Tobiasz Cudnik

Status: review_failed → review

We should also remove imagecacher.js and it's references in packager and loader files, which is what the second patch does.

comment:6 Changed 16 years ago by Garry Yao

Status: review → review_failed

The "preload" definition in skin file is useless at the moment.

Changed 16 years ago by Tobiasz Cudnik

Attachment: 6502_3.patch​ added

comment:7 Changed 16 years ago by Tobiasz Cudnik

Status: review_failed → review

Right, i've missed that.

comment:8 Changed 16 years ago by Garry Yao

Status: review → review_passed

comment:9 Changed 16 years ago by Tobiasz Cudnik

Resolution: → fixed
Status: review_passed → closed

Fixed with [6100].

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy