Ticket #6510 (closed Bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Margin mirroring doesn't respect style configuration

Reported by: garry.yao Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.4.3
Component: Core : Styles Version: 3.4
Keywords: Cc:

Description

Currently the 'indent' and 'justify' plugin that on behavior of 'dirChange' event doesn't consider class-based styling configuration e.g. 'justifyClasses' and 'indentClasses'.

Attachments

6510.patch (1.2 KB) - added by tobiasz.cudnik 3 years ago.
6510_2.patch (3.5 KB) - added by tobiasz.cudnik 3 years ago.

Change History

comment:1 Changed 3 years ago by garry.yao

  • Status changed from new to confirmed

comment:2 Changed 3 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from confirmed to assigned

comment:3 Changed 3 years ago by fredck

  • Milestone changed from CKEditor 3.5 to CKeditor 3.4.3

comment:4 Changed 3 years ago by tobiasz.cudnik

  • Status changed from assigned to review

We can't mirror indentClasses, as they are linear. What we can do about them is to introduce a dedicated setting to the config named eg indentClassesRtl. Then it would be possible.

Changed 3 years ago by tobiasz.cudnik

comment:5 Changed 3 years ago by garry.yao

  • Status changed from review to review_failed

Ok, I believe that it's enough to append the original class name a "_RTL"? Unfortunately there's no RTL CSS selector ;)

Changed 3 years ago by tobiasz.cudnik

comment:6 Changed 3 years ago by tobiasz.cudnik

  • Status changed from review_failed to review

Second patch uses "_rtl" prefix for indentClasses. Additionally, dirChange event now send an explicit information about new direction.

comment:7 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed

Ok, looks good, be sure to append the following to _samples\assets\output_xhtml.css

.Indent1_rtl
{
	margin-right: 40px;
}

.Indent2_rtl
{
	margin-right: 80px;
}

.Indent3_rtl
{
	margin-right: 120px;
}

comment:8 Changed 3 years ago by tobiasz.cudnik

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [6068], including output_xhtml.css changes.

comment:9 Changed 3 years ago by tobiasz.cudnik

Committed into correct branch with [6087].

comment:10 Changed 3 years ago by alfonsoml

This change has caused #6772

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy