Opened 7 years ago

Closed 7 years ago

#6513 closed Bug (fixed)

ARIA list property incorrect in "stylescombo"

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.3
Component: Accessibility Version: 3.2
Keywords: Firefox Cc:

Description

Open styles combo and check the the "aria-setsize" attribute that presented on list item link, undefined is found there, it breaks the understanding of list structure for screen readers.

Attachments (2)

6513.patch (364 bytes) - added by Garry Yao 7 years ago.
6513_2.patch (616 bytes) - added by Frederico Caldeira Knabben 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Garry Yao

Attachment: 6513.patch added

comment:1 Changed 7 years ago by Garry Yao

Status: newconfirmed

comment:2 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.5CKEditor 3.4.3

comment:3 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewassigned

I'm not able to reproduce this problem. aria-setsize is properly set. Do you have more info?

comment:5 Changed 7 years ago by Garry Yao

Status: assignedpending

Styles combo/Firefox3.6.12, original message from JAWS team:

 The posinset and setsize values seem to be incorrect on the
"format styles" list.  On
http://nightly.ckeditor.com/5934/_samples/replacebyclass.html click on the
"format styles" button and you get a list of options.  Looking at the
IAccessible information I see strange values for posinset and setsize for
the items in the list (this is a previously reported issue with FF 3.6).

comment:6 Changed 7 years ago by Garry Yao

Keywords: Firefox added

comment:7 Changed 7 years ago by Garry Yao

Status: pendingreview

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: 6513_2.patch added

comment:8 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

It's not my intention to take over the ticket, but considering that it's wrong to access private variables from other parts of the code, I was wondering if the attached solution would be proper to fix it.

If you feel it's ok, please go ahead committing it directly.

comment:9 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_failedclosed

Fixed with [6140].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy