Opened 14 years ago
Closed 14 years ago
#6566 closed Bug (fixed)
Impossible to get out of blockquote on enterMode = BR
| Reported by: | Sa'ar Zac Elias | Owned by: | Sa'ar Zac Elias |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.5.1 |
| Component: | Core : Styles | Version: | |
| Keywords: | Cc: | pomu@… |
Description (last modified by )
- Set enterMode = BR and open a sample.
- Type 3 rows.
- Apply blockquote.
Note that *everything* is inside the blockquote. You can not get out of it.
IMHO, it should act like that:
- If the selection is not collapsed, only transform the selected rows into blockquote.
- If the selection is collapsed, the row in which the caret is placed should be the blockquote.
- Exiting the blockquote could be done when clicking the blockquote button again.
Also, what do you think of having a possibility to exit a blockquote with double-Enter, just like exiting a list item?
Attachments (1)
Change History (13)
comment:1 Changed 14 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 14 years ago by
| Keywords: | Discussion added |
|---|---|
| Type: | Bug → New Feature |
comment:3 Changed 14 years ago by
comment:5 Changed 14 years ago by
| Component: | General → Core : Styles |
|---|---|
| Keywords: | Discussion removed |
| Milestone: | → CKEditor 3.5.1 |
| Status: | new → confirmed |
| Type: | New Feature → Bug |
@gav Thanks for the remind, it's indeed a bug, "div" plugin is also affected AFAIK, the "new feature" I'm seeing in the ticket is actually the proposal of "having a possibility to exit a blockquote with double-Enter, just like exiting a list item".
comment:6 Changed 14 years ago by
I would be cautious regarding the double ENTER thing. Especially when enterMode=BR, the user may want to stay into the blockquote to separate blocks of texts on it.
As it's possible to leave the blockquote by clicking its relative button, let's fix the bug first, leaving this new feature for future discussions.
comment:7 Changed 14 years ago by
| Cc: | pomu@… added |
|---|
Changed 14 years ago by
| Attachment: | 6566.patch added |
|---|
comment:8 Changed 14 years ago by
| Owner: | set to Sa'ar Zac Elias |
|---|---|
| Status: | confirmed → review |
comment:9 Changed 14 years ago by
| Status: | review → review_passed |
|---|
The patch fixes exiting from a blockquote in entermode BR by using a toolbar button.
comment:10 follow-up: 11 Changed 14 years ago by
| Status: | review_passed → review_failed |
|---|
But why there's an extra paragraph created automatically there in blockquote?
comment:11 Changed 14 years ago by
comment:12 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_failed → closed |
Fixed with [6264].
I know this is marked as "New Feature", but I think it should be marked as a bug. FCK did not work like this, if you had content that only had BRs in it, it would still only indent one "paragraph", not the whole document. This is definitely a regression from the FCK version of the plugin. If needed, I can stand up a test environment to demonstrate the regression.