Opened 14 years ago
Closed 14 years ago
#6573 closed Bug (invalid)
Refactoring: Indent command doesn't share a big chunk of logic across executions
| Reported by: | Tobiasz Cudnik | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | Refactoring | Cc: |
Description
Refactoring: Indent command doesn't share a big chunk of logic across executions.
Particularly, these functions from the Indent plugin are recreated each time the Indent command is executed (128 lines of code):
- indentList
- indentBlock
- indentElement
This causes an unnecessary memory allocation and deallocation.
Change History (2)
comment:1 Changed 14 years ago by
| Keywords: | Refactoring added; Refacoring removed |
|---|
comment:2 Changed 14 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
The performance impact of a closure should be measured by the amount of function execution, here the command::exec method is definitely NOT a massive running one, note that the benefit of closure could also help us save some extra bits.