Opened 7 years ago

Closed 7 years ago

#6604 closed Bug (fixed)

Bidi and Justify plugins should create the same element [enterMode BR]

Reported by: Sa'ar Zac Elias Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: General Version: 3.0
Keywords: Discussion Cc:

Description

Currently, when enterMode is BR, justifying text results in a paragrpah, and adding direction results in a DIV. In both cases paragraph should be used.

Attachments (1)

6604.patch (1.1 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Please note that with enterMode BR, all block like operations must result in a <div>, not a <p>. This is by design.

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.3CKEditor 3.5.1

comment:3 in reply to:  1 Changed 7 years ago by Garry Yao

Keywords: Discussion added

Replying to fredck:

Please note that with enterMode BR, all block like operations must result in a <div>, not a <p>. This is by design.

I'm sure this's not respected at all in v3, works like you describe in v2 though, so looks like a serious bug.

comment:4 Changed 7 years ago by Garry Yao

Status: newconfirmed
Version: 3.0

comment:5 Changed 7 years ago by Tobiasz Cudnik

So what is the issue here? Plugins which are using P for "block like operations" in entermode BR?

Changed 7 years ago by Garry Yao

Attachment: 6604.patch added

comment:6 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6273].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy