Opened 7 years ago

Closed 7 years ago

#6614 closed Bug (fixed)

Resize handler in RTL UI

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.3
Component: UI : Toolbar Version:
Keywords: Cc:

Description

Now resize handler is placed at "l-b" in RTL UI language, this create a broken dragging experience as editor chrome is left-aligned in host page (expands at right hand side) when dragging.

Attachments (3)

6614.patch (2.8 KB) - added by Garry Yao 7 years ago.
6614_2.patch (3.7 KB) - added by Garry Yao 7 years ago.
6614_3.patch (8.5 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Keywords: Discussion removed
Status: newconfirmed

The editor should definitely be resized to the opposite side.

comment:2 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.2

comment:3 Changed 7 years ago by Sa'ar Zac Elias

Note: when the editor is placed inside a RTL container, it does resizes correctly.

Changed 7 years ago by Garry Yao

Attachment: 6614.patch added

comment:4 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

Totally 4 scenarios targeted, editor UI direction(2) * editor environment direction(2)

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Dialog resizing was also affected.

Changed 7 years ago by Garry Yao

Attachment: 6614_2.patch added

comment:6 Changed 7 years ago by Garry Yao

Status: review_failedreview

Dialog case is a bit different, because of the modal-less nature, resize handler could reflect simply the UI direction.

Changed 7 years ago by Garry Yao

Attachment: 6614_3.patch added

comment:7 Changed 7 years ago by Garry Yao

Switch to use CSS "right" for dialog positioning, while keep dialog::move back-compat, in this way the RTL resize logic are much simpler.

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:9 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6454].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy