Opened 8 years ago

Last modified 7 years ago

#6615 review_failed Bug

[IE] tableresize usability

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: General Version: 3.4 Beta
Keywords: IE Cc:

Description

The changes of [5747] introduced the following problems in IE:

  1. Column resizer's position doesn't accurately reflect cell spaces, few pixels offset makes the resizer always appear before mouse is actually moved into;
  2. The cursor shape is inconsistent with other browsers, even composed of two sharps when moving along the visible region.

Attachments (4)

6615.patch (985 bytes) - added by Garry Yao 7 years ago.
6615_2.patch (1.6 KB) - added by Garry Yao 7 years ago.
6615_3.patch (1.9 KB) - added by Garry Yao 7 years ago.
6615_4.patch (2.9 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4.3CKEditor 3.5.1

comment:2 Changed 8 years ago by Garry Yao

Under IE7 the column pillar appears without clicking down mouse button.

comment:3 Changed 7 years ago by Sa'ar Zac Elias

Status: newconfirmed

I can reproduce first & second TCs when gripping the resizer from near the cell border (could be done easily with bigger cellpadding value).

comment:4 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

By back-tracing I understand that the issue was originated from #5890, affects only below IE8.

Changed 7 years ago by Garry Yao

Attachment: 6615.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:6 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6322].

comment:7 Changed 7 years ago by Wiktor Walc

Resolution: fixed
Status: closedreopened

6615.patch caused #7081 and #7083

comment:8 Changed 7 years ago by Garry Yao

Status: reopenedconfirmed

We decide to revert the fix with [6388].

comment:9 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1CKEditor 3.5.2

The patch from #7083 seems to fix both reported problems, needs deeper testing though.

Changed 7 years ago by Garry Yao

Attachment: 6615_2.patch added

comment:10 Changed 7 years ago by Garry Yao

Status: confirmedreview

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

IE7:
Create a table, put contents in first and second cells and select their contents using the mouse. Now click on the border between them and drag it a bit. Once one releases the grip, the selection is lost.

Changed 7 years ago by Garry Yao

Attachment: 6615_3.patch added

comment:12 Changed 7 years ago by Garry Yao

Status: review_failedreview

New patch addresses the selection lost issue.

comment:13 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

IE7 mode, create a table and put a list in the rightmost cell in the top row. Click and drag the border between the cells. Note that the resizer does not appear correctly.

Changed 7 years ago by Garry Yao

Attachment: 6615_4.patch added

comment:14 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:15 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

IE7 is still broken:

  • Put the cursor at the top-rightmost cell. Click on the list button.
  • Without changing the selection, hover over the border.
    • See that helper does not appear.
  • Now switch to source and then back to wysiwyg.
  • Hover over the middle border.
    • Note that the left side is "disappearing", while it's still intact in source.

Another issue: do as described in comment:11. Note that the focus is lost.

comment:16 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy