Opened 7 years ago

Closed 7 years ago

#6640 closed Bug (fixed)

Combobox not disabled when switching in source view

Reported by: fournaise Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4.3
Component: UI : Floating Panel Version: 3.0
Keywords: Cc:

Description

See screencast in attachment.

Attachments (6)

step1.gif (40.4 KB) - added by fournaise 7 years ago.
step 1
step2.gif (14.2 KB) - added by fournaise 7 years ago.
step 2
6640.patch (780 bytes) - added by Sa'ar Zac Elias 7 years ago.
6640_2.patch (922 bytes) - added by Sa'ar Zac Elias 7 years ago.
6640_3.patch (1.8 KB) - added by Sa'ar Zac Elias 7 years ago.
6640_4.patch (1.5 KB) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (17)

Changed 7 years ago by fournaise

Attachment: step1.gif added

step 1

Changed 7 years ago by fournaise

Attachment: step2.gif added

step 2

comment:1 Changed 7 years ago by fournaise

Version: 3.4.2

comment:2 Changed 7 years ago by Garry Yao

Component: GeneralUI : Floating Panel
Milestone: CKEditor 3.4.3
Status: newconfirmed
Version: 3.4.23.0

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6640.patch added

comment:3 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

comment:4 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Fixing at the low leve (float panel) will leave the combobox active in source mode.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6640_2.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

Note #6656.

comment:6 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

menubutton should be included also.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6640_3.patch added

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:8 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Note that menu button is triple stated, considering when SCAYT is enabled.

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6640_4.patch added

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

comment:10 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: review_passedclosed

Fixed with [6095].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy