Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#6639 closed Bug (fixed)

Pasting from Word a nested list with an empty paragraph doesn't work

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.1
Component: Plugin : Paste from Word Version: 3.1
Keywords: Cc:

Description

When there is a list with another nested list, that contains an empty paragraph created with Shift+Enter, pasting from Word generates an invalid result.

Word document:

 1.	One
    a.	Nested list 1
    b.	Nested list 2

    c.	Nested list 3
    d.	Nested list 4
 2.	Two
 3.	Three
 4.	Four

result after pasting from Word into CKEditor:

 1.One
    1.Nested list 1
    2.Nested list 2




 1.Nested list 3
 2.Nested list 4
 3.Two
 4.Three
 5.Four 

Attachments (4)

nested_list_with_empty_lines.docx (13.6 KB) - added by Wiktor Walc 7 years ago.
6639.patch (623 bytes) - added by Tobiasz Cudnik 7 years ago.
6639_2.patch (1.4 KB) - added by Garry Yao 7 years ago.
6639_3.patch (1.0 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (17)

Changed 7 years ago by Wiktor Walc

comment:1 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.6CKEditor 3.5.1

comment:2 Changed 7 years ago by Garry Yao

Status: newconfirmed
Version: 3.1

To not make the TC complicated, the bug is just about pasting the nested list, we must understand how line-break (SHIFT-ENTER) affects our list resolution.

comment:3 Changed 7 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: confirmedassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6639.patch added

comment:4 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

The solution is really simple, although finding the reason weren't. I think there can be more places suffering from lack of the XML namespace support in our codebase...

Changed 7 years ago by Garry Yao

Attachment: 6639_2.patch added

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

I don't see the patch fix the problem, also, we need to keep namespaced elements intact with "cke" as prefix, see flash plugin.

comment:6 Changed 7 years ago by Garry Yao

Owner: changed from Tobiasz Cudnik to Garry Yao
Status: review_failedreview

comment:7 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

I'm not sure if we should mix up our own things in the dtd.

comment:8 Changed 7 years ago by Garry Yao

Status: review_failedreview

Dollar prefixed dtd entries are all "none-generated" definitions that were added by us as additional semantics.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

We can inline the tag name for that, no need for another dtd entry.

Changed 7 years ago by Garry Yao

Attachment: 6639_3.patch added

comment:10 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:12 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6317].

comment:13 Changed 3 years ago by Frederico Caldeira Knabben

Component: Core : PastingPlugin : Paste from Word
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy