Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6638 closed New Feature (duplicate)

Unify the way of setting color in CSS styles

Reported by: Wiktor Walc Owned by:
Priority: Normal Milestone:
Component: Core : Output Data Version:
Keywords: Cc: Alfonso Martínez de Lizarrondo

Description

Right now the result of applying a color to selected text is different.

  • IE: <span style="color: #ff0000">
  • Firefox: <span style="color: rgb(255, 0, 0);">

If we edit in Firefox an article created in IE we are causing lots of changes in the source, which is a problem in environments that support versioning. Checking changes between various revisions is much harder in such situation.

Another problem is that there are systems that do some security checks on inline styles and they do not always respect rgb() notation, so the color is lost there.

Change History (5)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Component: GeneralCore : Output Data
Milestone: CKEditor 3.5.1
Status: newconfirmed

I think we already have a ticket for it, but I'm not totally sure.

comment:2 Changed 9 years ago by Garry Yao

Cc: Alfonso Martínez de Lizarrondo added

comment:3 Changed 9 years ago by Alfonso Martínez de Lizarrondo

I proposed a patch that handles these problems in #1653. Then problem isn't only the color, all the style css can be modified by each browser and currently there's no protection as the css unification is done only while adding, not when the data is get back.

comment:4 Changed 9 years ago by Wiktor Walc

Resolution: duplicate
Status: confirmedclosed

This is actually covered by #1653 as Alfonso wrote, so marking as a duplicate.

comment:5 Changed 9 years ago by Wiktor Walc

Milestone: CKEditor 3.5.1
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy