Opened 7 years ago

Closed 7 years ago

#6644 closed Task (fixed)

Restrict onmousedown listener to the toolbar

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.4.3
Component: UI : Toolbar Version:
Keywords: Cc:

Description

Follow up from #6416

Currently the whole editor wrapper has an onmousedown = return false, and it seems that the aim is to avoid problems with the toolbar.

So the proper solution seems to move the listener just to the toolbar and remove the "strange" code in the sourcearea plugin.

Attachments (1)

6644.patch (2.0 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6644.patch added

Proposed patch

comment:1 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Status: newreview

We must check that there's nothing else broken by this change.

comment:2 Changed 7 years ago by Garry Yao

Component: GeneralUI : Toolbar
Milestone: CKEditor 3.4.3
Status: reviewreview_passed
Type: BugTask

comment:3 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: review_passedclosed

Fixed with [6057]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy