Ticket #6416 (closed Bug: fixed)

Opened 4 years ago

Last modified 3 years ago

Disabled selection of text by mouse in Source editing under IE9

Reported by: krst Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Source View Version: 3.4.1
Keywords: IE Cc:

Description

Under IE9

  • open CKEditor demo
  • switch to source editing
  • try to select source text by mouse

Expected: Range of text is selected

Actual: selection is disabled for mouse. I am able to select text by keyboard.
In WYSIWYG, selection by mouse works fine

Attachments

6416.patch (927 bytes) - added by alfonsoml 4 years ago.
Proposed patch
6416_2.patch (1.3 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 4 years ago by krst

  • Keywords IE9 added

comment:2 Changed 4 years ago by tobiasz.cudnik

  • Keywords IE added; IE9 removed
  • Milestone set to CKEditor 3.4.2

comment:3 Changed 4 years ago by alfonsoml

  • Status changed from new to review
  • Owner set to alfonsoml
  • Component changed from General to UI : Source View

It seems that IE9 is following just the same behavior that other browsers have, so now we have to apply a workaround also for it.

It would be nice to really understand why this is happening and avoid it altogether for every browser, but meanwhile this will make the mouse work in source mode for IE9

Changed 4 years ago by alfonsoml

Proposed patch

Changed 4 years ago by garry.yao

comment:4 Changed 4 years ago by garry.yao

  • Status changed from review to review_failed

Let's just remove it now until somebody shout out the usage of that line.

comment:5 Changed 4 years ago by garry.yao

  • Owner changed from alfonsoml to garry.yao
  • Status changed from review_failed to review

comment:6 Changed 4 years ago by alfonsoml

  • Status changed from review to review_failed

If the onmousedown handler is removed, clicking the Source button generates an error in Firefox 3.6

editor.document is null
-> editor.document.$.designMode = 'off'; 

comment:7 Changed 3 years ago by garry.yao

  • Status changed from review_failed to review

'onmousedown=false' on container is actually a focus stopper for toolbar buttons, that prevent click on toolbar button from stealing focus away from editor, we must keep in still. R+ for 6416, but may alter tune on "by some yet unknown reason".

comment:8 Changed 3 years ago by garry.yao

  • Status changed from review to review_passed

comment:9 Changed 3 years ago by garry.yao

  • Status changed from review_passed to closed
  • Resolution set to fixed

Fixed with [5965].

comment:10 Changed 3 years ago by alfonsoml

Filed #6644 to try to remove the code as proposed in the second patch.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy