Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6416 closed Bug (fixed)

Disabled selection of text by mouse in Source editing under IE9

Reported by: Krzysztof Studnik Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: UI : Source View Version: 3.4.1
Keywords: IE Cc:

Description

Under IE9

  • open CKEditor demo
  • switch to source editing
  • try to select source text by mouse

Expected: Range of text is selected

Actual: selection is disabled for mouse. I am able to select text by keyboard.
In WYSIWYG, selection by mouse works fine

Attachments (2)

6416.patch (927 bytes) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Proposed patch
6416_2.patch (1.3 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Krzysztof Studnik

Keywords: IE9 added

comment:2 Changed 7 years ago by Tobiasz Cudnik

Keywords: IE added; IE9 removed
Milestone: CKEditor 3.4.2

comment:3 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Component: GeneralUI : Source View
Owner: set to Alfonso Martínez de Lizarrondo
Status: newreview

It seems that IE9 is following just the same behavior that other browsers have, so now we have to apply a workaround also for it.

It would be nice to really understand why this is happening and avoid it altogether for every browser, but meanwhile this will make the mouse work in source mode for IE9

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: 6416.patch added

Proposed patch

Changed 7 years ago by Garry Yao

Attachment: 6416_2.patch added

comment:4 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

Let's just remove it now until somebody shout out the usage of that line.

comment:5 Changed 7 years ago by Garry Yao

Owner: changed from Alfonso Martínez de Lizarrondo to Garry Yao
Status: review_failedreview

comment:6 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Status: reviewreview_failed

If the onmousedown handler is removed, clicking the Source button generates an error in Firefox 3.6

editor.document is null
-> editor.document.$.designMode = 'off'; 

comment:7 Changed 7 years ago by Garry Yao

Status: review_failedreview

'onmousedown=false' on container is actually a focus stopper for toolbar buttons, that prevent click on toolbar button from stealing focus away from editor, we must keep in still. R+ for 6416, but may alter tune on "by some yet unknown reason".

comment:8 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:9 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [5965].

comment:10 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Filed #6644 to try to remove the code as proposed in the second patch.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy