Opened 7 years ago

Closed 6 years ago

#6664 closed Bug (fixed)

Extra Space between Page Breaks after moving from Source to Wysiwyg mode.

Reported by: naresh.sivaraman Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6
Component: General Version: 3.4.2
Keywords: Oracle Cc:

Description

Tested in IE8.

To reproduce: (1)Add two page breaks on the editor. (2)Remove the line(gap) between them. (3)Go to source and come back to wysiwyg. (4)The line and the gap is back.

Issue is happening because on doing step 2, the div of the second page break falls inside the <p>. This can be seen when we move to source. So, when we come back to wysiwyg, the <p> is closed with a &nbsp;</p> and the div is seperate.

Attachments (6)

ckeditor_bug_pb.txt (556 bytes) - added by naresh.sivaraman 7 years ago.
6664.patch (5.7 KB) - added by Garry Yao 7 years ago.
6664_2.patch (7.0 KB) - added by Garry Yao 6 years ago.
6664_3.patch (7.1 KB) - added by Garry Yao 6 years ago.
6664_4.patch (7.0 KB) - added by Garry Yao 6 years ago.
6664_5.patch (7.1 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (21)

Changed 7 years ago by naresh.sivaraman

Attachment: ckeditor_bug_pb.txt added

Changed 7 years ago by Garry Yao

Attachment: 6664.patch added

comment:1 Changed 7 years ago by Garry Yao

Milestone: CKEditor 3.5.1
Status: newconfirmed

We've been suffering from the problem that the fake elements (image) that we use were treated by the browser as they were, even it's been displayed as block.

After 3.4, we introduced the contenteditable support, a nice substitution of fake elements in certain cases, the advantages include:

  1. True semantic (no more '_cke_real_element_type' );
  2. Better performance on output(no fake element transformation);

The patch propose an attempt in this approach.

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.5.1CKEditor 3.6

comment:3 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

The bug affects also FF.

comment:4 Changed 6 years ago by Wiktor Walc

Keywords: Oracle added

comment:5 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Patch should be updated.

Changed 6 years ago by Garry Yao

Attachment: 6664_2.patch added

comment:6 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed
  • Add a page break. Click it.
  • See that the format combo displays div. Open the combo and click on div.

Note that a bookmark is being added above.

comment:8 Changed 6 years ago by Garry Yao

Status: review_failedreview

Ok, I've made a change to styles plugin which disallows style change on read-only blocks.

Changed 6 years ago by Garry Yao

Attachment: 6664_3.patch added

comment:9 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The object now becomes unselectable thus it cannot be dragged (IE at least). This is counterintuitive. Note that this attribute should not be outputed, in any case.

Changed 6 years ago by Garry Yao

Attachment: 6664_4.patch added

comment:10 Changed 6 years ago by Garry Yao

Status: review_failedreview

comment:11 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_failed
  • Create the following selection:
    <p>
    	text [text text</p>
    <div style="page-break-after: always;" title="Page Break">
    	<span style="display: none;">&nbsp;</span></div>
    <p>
    	text text] text</p>
    
  • In the format combo, choose "heading 2".

Result: div is transformed into h2.
Also, on output, the page break should not have the title attribute.

Changed 6 years ago by Garry Yao

Attachment: 6664_5.patch added

comment:12 Changed 6 years ago by Garry Yao

Status: review_failedreview

The style application issue is a current editor limitation, filed #7694.

comment:13 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:14 Changed 6 years ago by Garry Yao

Fixed with [6764], thanks Saar for the high quality review.

comment:15 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy