Opened 7 years ago

Closed 7 years ago

#6670 closed Bug (fixed)

BIDI: Indent & List icons are not reversed when we apply RTL direction to a paragraph with any of Paragraph Formatting options

Reported by: Satya Minnekanti Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.4.3
Component: Core : BiDi Version: 3.4.2
Keywords: IBM Cc: Damian, joek, james c

Description

To reproduce the defect:

  1. Open the Ajax sample.
  1. Type some text, select the text & apply any of the Paragraph Formatting options(H1 to H6 or Address etc).
  1. Click on RTL icon.

Expected Result:

Direction of list & indent icons should be reversed to reflect the change to RTL language direction.

Actual Result:

Direction of list & indent icons are not reversed to reflect the change to RTL language direction.

Attachments (2)

6670.patch (1.3 KB) - added by Tobiasz Cudnik 7 years ago.
6670_2.patch (608 bytes) - added by Tobiasz Cudnik 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Tobiasz Cudnik

Milestone: CKEditor 3.4.3
Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6670.patch added

comment:2 Changed 7 years ago by Tobiasz Cudnik

Status: assignedreview

comment:3 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

For me we could simply check the computed direction of the path block/blockLimit?

Changed 7 years ago by Tobiasz Cudnik

Attachment: 6670_2.patch added

comment:4 in reply to:  3 Changed 7 years ago by Tobiasz Cudnik

Status: review_failedreview

Replying to garry.yao:

For me we could simply check the computed direction of the path block/blockLimit?

Right, it seems to be a simpler approach which still fixes the problem.

comment:5 Changed 7 years ago by Garry Yao

Component: GeneralCore : BiDi
Status: reviewreview_passed

comment:6 Changed 7 years ago by Tobiasz Cudnik

Resolution: fixed
Status: review_passedclosed

Fixed with [6094].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy