Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6829 closed Bug (fixed)

Spell Check dialog should be resizable

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Dialogs Version: 3.5
Keywords: Cc: WebSpellChecker.net

Description

The spell check dialog is one of the most hard to use things inside of CKEditor. The problem is that the default window where the content is shown is very tiny. It's hard to find out in what place exactly we are in the document.

Being able to resize this dialog would definitely make things easier. Resizing this dialog should simply result in enlarging the table cell where content is displayed (<td class="midtext">)

Attachments (3)

ckeditor_check_spelling.png (48.1 KB) - added by Wiktor Walc 7 years ago.
6829.patch (1.5 KB) - added by Garry Yao 7 years ago.
6829_2.patch (1.5 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by Wiktor Walc

Attachment: ckeditor_check_spelling.png added

comment:1 Changed 7 years ago by Wiktor Walc

Component: GeneralUI : Dialogs

comment:2 Changed 7 years ago by WebSpellChecker.net

Could you provide us some more info about resizing dialogs in CKEditor?

We have found that dialog has property "resizable", which could be CKEDITOR.DIALOG_RESIZE_NONE, CKEDITOR.DIALOG_RESIZE_WIDTH, CKEDITOR.DIALOG_RESIZE_HEIGHT, CKEDITOR.DIALOG_RESIZE_BOTH. However, the only dialog that uses this property is "Find" dialog and it sets "resizable : CKEDITOR.DIALOG_RESIZE_NONE". We have tried these different options both with WSC and Find dialogs, but they did not change dialogs' behavior. Is there any other way may CKeditor's dialogs to resize as seen on picture with arrows in the bottom right corner?

comment:3 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

We'll handle this ticket.

Changed 7 years ago by Garry Yao

Attachment: 6829.patch added

comment:4 Changed 7 years ago by Garry Yao

Status: assignedreview

The patch make it at least possible to resize the content area, rest of adapting changes are to be tackled by SpellChecker.net server after this milestone.

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

The editor fails to open other dialogs after the patch.

Changed 7 years ago by Garry Yao

Attachment: 6829_2.patch added

comment:6 Changed 7 years ago by Garry Yao

Status: review_failedreview

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6217], please open new tickets for other problems.

comment:9 Changed 7 years ago by Sa'ar Zac Elias

Correct patch was committed with [6222].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy