Opened 8 years ago

Closed 8 years ago

#6830 closed Bug (fixed)

Use editor.lang.common in the iframe (flash, image) dialog

Reported by: Wiktor Walc Owned by: Wiktor Walc
Priority: Normal Milestone: CKEditor 3.5
Component: UI : Language Version: 3.5
Keywords: Cc:


We have introduced a new dialog that contains words that are already used in other places:

  • Width
  • Height
  • validateWidth / Height
  • Alignment options

To reduce the size of language files and make the fresh release of CKEditor looking better in languages other than English (getting new translations from contributors always take some time), let's do some cleanup with the common words we have used there and ensure that those strings would be translated correctly in 3.5.

Note that the context in the Flash and Image dialogs is exactly the same for those strings, so we're safe with reusing those values.

Attachments (2)

6830.patch (299.6 KB) - added by Wiktor Walc 8 years ago.
6830_2.patch (299.9 KB) - added by Wiktor Walc 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by Wiktor Walc

Owner: set to Wiktor Walc
Status: newassigned

Changed 8 years ago by Wiktor Walc

Attachment: 6830.patch added

comment:2 Changed 8 years ago by Wiktor Walc

Status: assignedreview

Note that this patch does not cover all the changes that could be made to reduce the size of language files. We'll do it in CKEditor 4.x. It just takes care of words described in the ticket. The iFrame dialog should look now better though.

lang.common language entries were created in the following way:

CKEDITOR.lang['{$lang}'].common.width = CKEDITOR.lang['{$lang}'].image.width;
CKEDITOR.lang['{$lang}'].common.height		= CKEDITOR.lang['{$lang}'].image.height;
CKEDITOR.lang['{$lang}'].common.align = CKEDITOR.lang['{$lang}'].flash.align;
CKEDITOR.lang['{$lang}'].common.alignLeft		= CKEDITOR.lang['{$lang}'].flash.alignLeft;
CKEDITOR.lang['{$lang}'].common.alignRight		= CKEDITOR.lang['{$lang}'].flash.alignRight;
CKEDITOR.lang['{$lang}'].common.alignCenter		= CKEDITOR.lang['{$lang}'].table.alignCenter;
CKEDITOR.lang['{$lang}'].common.alignTop		= CKEDITOR.lang['{$lang}'].flash.alignTop;
CKEDITOR.lang['{$lang}'].common.alignMiddle		= CKEDITOR.lang['{$lang}'].flash.alignMiddle;
CKEDITOR.lang['{$lang}'].common.alignBottom		= CKEDITOR.lang['{$lang}'].flash.alignBottom;
CKEDITOR.lang['{$lang}'].common.invalidHeight	= CKEDITOR.lang['{$lang}'].flash.validateHeight;
CKEDITOR.lang['{$lang}'].common.invalidWidth	= CKEDITOR.lang['{$lang}'].flash.validateWidth;

By checking all the language files it turned out that lang.flash entries are correctly translated in almost all places.

comment:3 Changed 8 years ago by Sa'ar Zac Elias

Status: reviewreview_failed

Putting an invalid value for the height or width fields in the iFrame dialog does not trigger the alert.

Changed 8 years ago by Wiktor Walc

Attachment: 6830_2.patch added

comment:4 Changed 8 years ago by Wiktor Walc

Status: review_failedreview

comment:5 Changed 8 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:6 Changed 8 years ago by Wiktor Walc

Resolution: fixed
Status: review_passedclosed

Fixed with [6207], updated translation status with [6208].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy