Ticket #6832 (closed Bug: invalid)

Opened 3 years ago

Last modified 4 weeks ago

improper page-break plugin

Reported by: yiminghe Owned by:
Priority: Normal Milestone:
Component: General Version: 3.4.3
Keywords: Cc:

Description

page-break is not only used when printing ,but mostly it is used by backend program to split a long post for paging.

steps :

1.set the following code to editor :

<div style="border: 10px solid green;">
	<p>
		123456</p>
</div>

2.put cursor between '3' and '4' ,and click page-break button, code generated by current version:

<div style="border: 10px solid green;">
	<p>
		123</p>
	<div style="page-break-after: always;">
		<span style="display: none;">&nbsp;</span></div>
	<p>
		456</p>
</div>

if the backend program splits it without html parsing , then each part of its content is malformed

so i think page-break should generate such code :

<div style="border: 10px solid green;">
	<p>
		123</p>
</div>
<div style="page-break-after: always;">
	<span style="display: none;">&nbsp;</span></div>
<div style="border: 10px solid green;">
	<p>
		456</p>
</div>

and above code is better for printing and splitting .

Attachments

before.png (7.7 KB) - added by yiminghe 3 years ago.
after.png (6.0 KB) - added by yiminghe 3 years ago.
6832.patch (1.0 KB) - added by yiminghe 3 years ago.
patch from trunk

Change History

Changed 3 years ago by yiminghe

Changed 3 years ago by yiminghe

Changed 3 years ago by yiminghe

patch from trunk

comment:1 Changed 3 years ago by garry.yao

  • Status changed from new to closed
  • Resolution set to invalid

Note that page-break is a page media only feature, which should impose at all no DOM structure deconstruction, with you proposition, a table will never have a chance to get spread over two transparencies (same as with other elements).

Instead, imposing that server-side content division based on page-break feature is simply wrong, please, just create the proper plugin to do that, editor core being incapable of handling such a luggage.

comment:2 Changed 4 weeks ago by wwalc

  • Keywords page-break removed
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy