Opened 7 years ago

Last modified 6 years ago

#6835 review_failed Bug

A few dialogs' content is not resiable

Reported by: Sa'ar Zac Elias Owned by: Sa'ar Zac Elias
Priority: Normal Milestone:
Component: UI : Dialogs Version: 3.5
Keywords: Discussion Cc:

Description

In a few dialog we have fixed width for content, so the dialog is resizable but the content size is never changed.
We need to make the content resizable (or cancel the resizing option of them).

  • Spell checker (covered by #6829).
  • Paste.
  • Special characters.
  • Select color.

Attachments (3)

Dialog-Window-Resizing-Find-Replace.png (12.2 KB) - added by Anna Tomanek 7 years ago.
Find and Replace dialog window with the resizing grip missing
6835.patch (5.0 KB) - added by Sa'ar Zac Elias 7 years ago.
6835_ref.patch (2.8 KB) - added by Garry Yao 7 years ago.
Patch enables vertical stretch in dialog

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Garry Yao

Status: newconfirmed

Unfortunately for "specialchar" and "color picker" due to grid(table) layout, a liquid layout is never achievable.

comment:2 Changed 7 years ago by Wiktor Walc

Milestone: CKEditor 3.5CKEditor 3.5.1

Changed 7 years ago by Anna Tomanek

Find and Replace dialog window with the resizing grip missing

comment:3 Changed 7 years ago by Anna Tomanek

I don't know whether it's the same issue or not, but in v3.5 the Find and Replace dialog window is NOT resizable and does NOT contain the resizing grip icon.

comment:4 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedassigned

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6835.patch added

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: assignedreview

The resizing of the find/replace dialog was disabled, but unless anyone objects, the patch enables the resizing of this dialog.

comment:6 Changed 7 years ago by Garry Yao

Status: reviewreview_failed

[6217] has been a misleading start to having those resizing logic boomed inside dialog codes, my intention is to have an 'onResize' handler introduced for each field in which we place the resize logic.

Note there's also another problem that v-resize looks meaningless at the moment, as for now table height doesn't stretch. I think we'd have to make that happen also.

Changed 7 years ago by Garry Yao

Attachment: 6835_ref.patch added

Patch enables vertical stretch in dialog

comment:7 Changed 7 years ago by Garry Yao

Keywords: Discussion added

A experimental patch to demonstrate vertical liquid layout, let's whether we could have it.

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.5.1CKEditor 3.5.2

comment:9 Changed 6 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy