Opened 7 years ago

Closed 6 years ago

#6849 closed Bug (fixed)

Paragragh tags should not be added inside <li> tags

Reported by: James Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.5.3
Component: Core : Lists Version: 3.4
Keywords: IBM Cc: Damian, joek, Satya Minnekanti

Description

Steps to Reproduce the defect:

  1. Open the Ajax sample.
  2. Click on the numbered list icon.
  3. Click on Heading 1 paragraph format.
  4. Type some text & press Enter.
  5. Type some more text & press Enter.

Expected: The source should look like this:

<ol>
	<li>
		<h1>Heading 1 List Item 1</h1>
	</li>
	<li>
		Normal List Item 2
	</li>
	<li>
		Normal List Item 3
	</li>
</ol>

Actual: But instead there are <p> tags added inside <li> tags so the output looks like this:

<ol>
	<li>
		<h1>Heading 1 List Item 1</h1>
	</li>
	<li>
		<p>Normal List Item 2</p>
	</li>
	<li>
		<p>Normal List Item 3</p>
	</li>
</ol>

Attachments (2)

6849.patch (2.0 KB) - added by Garry Yao 6 years ago.
6849_2.patch (1.6 KB) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Krzysztof Studnik

Status: newconfirmed
Version: 3.4.3 (SVN - trunk)3.4

Confirmed the redundant <p>'s are added

Changed 6 years ago by Garry Yao

Attachment: 6849.patch added

comment:2 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:3 Changed 6 years ago by Damian

Can we target this for a milestone?

comment:4 Changed 6 years ago by Wiktor Walc

Milestone: CKEditor 3.5.3

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

After patch:

  1. Load this:
<ul>
	<li>
		<h1>Some text</h1>
	</li>
</ul>
  1. Put the caret in the middle of "Some text".
  2. Hit ENTER.

An empty <h1> is appended to the first list item.

Changed 6 years ago by Garry Yao

Attachment: 6849_2.patch added

comment:6 Changed 6 years ago by Garry Yao

Status: review_failedreview

Um...looks like the first patch was just heading the wrong way, which doesn't take into consideration the inline style continuation.

comment:7 Changed 6 years ago by Sa'ar Zac Elias

Status: reviewreview_passed

comment:8 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [6563].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy