Opened 7 years ago

Closed 7 years ago

#6866 closed Bug (fixed)

Image link target field not correctly set when editing an existing image.

Reported by: Joe Kavanagh Owned by: Sa'ar Zac Elias
Priority: Normal Milestone: CKEditor 3.4.3
Component: General Version: 3.4.3
Keywords: IBM Cc: Satya Minnekanti, Damian, jamcunni@…

Description (last modified by Garry Yao)

  1. Open the image dialog.
  1. Fill in the image information.
  1. On the Link tab enter a URL and set the Target field to 'New Window'.
  1. Click OK to insert the image.
  1. Right click on the inserted image and choose Image Properties from the context menu.
  1. Click on the Link tab on the Image dialog.

Observe that the Target field is incorrectly set to '<not set>'. The anchor tag's target attribute does contain the correct value, '_blank'.

Attachments (1)

6866.patch (556 bytes) - added by Sa'ar Zac Elias 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by Sa'ar Zac Elias

Milestone: CKEditor 3.4.3
Status: newconfirmed

comment:2 Changed 7 years ago by Sa'ar Zac Elias

Regression of [6136].

Changed 7 years ago by Sa'ar Zac Elias

Attachment: 6866.patch added

comment:3 Changed 7 years ago by Sa'ar Zac Elias

Owner: set to Sa'ar Zac Elias
Status: confirmedreview

Reverted [6136] as I'm not able to reproduce #6673 anymore.

comment:4 Changed 7 years ago by Garry Yao

Description: modified (diff)
Status: reviewreview_failed

#6673 is still reproducible but just to add back the "if ( type == LINK )", as the dialog fields are setup twice.

comment:5 Changed 7 years ago by Sa'ar Zac Elias

Status: review_failedreview

Neither me or Tobiasz can reproduce #6673 after the patch.

comment:6 Changed 7 years ago by Tobiasz Cudnik

I can't reproduce #6673 anymore, but the TC of this ticket fails because of the second invocation of the setup, when it's value is correct, but the new value is null.

comment:7 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_failed

comment:8 Changed 7 years ago by Tobiasz Cudnik

Owner: changed from Sa'ar Zac Elias to Tobiasz Cudnik
Status: review_failedreview

I had some code changes when testing this TC, it works fine with 6866.patch.

comment:9 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:10 Changed 7 years ago by James

Cc: Satya Minnekanti Damian jamcunni@… added; satya damo removed

comment:11 Changed 7 years ago by Sa'ar Zac Elias

Owner: changed from Tobiasz Cudnik to Sa'ar Zac Elias
Status: review_passedassigned

comment:12 Changed 7 years ago by Sa'ar Zac Elias

Resolution: fixed
Status: assignedclosed

Fixed with [6223].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy